linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: rtg.canonical@gmail.com
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tim Gardner <tim.gardner@canonical.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>
Subject: [PATCH v2] fs: namespace: suppress 'may be used uninitialized' warnings
Date: Thu, 28 Aug 2014 07:55:49 -0600	[thread overview]
Message-ID: <1409234149-3485-1-git-send-email-tim.gardner@canonical.com> (raw)
In-Reply-To: <20140827210112.GE18016@ZenIV.linux.org.uk>

From: Tim Gardner <tim.gardner@canonical.com>

The gcc version 4.9.1 compiler complains even though it isn't possible for
these variables to not get initialized before they are used.

fs/namespace.c: In function ‘SyS_mount’:
fs/namespace.c:2720:8: warning: ‘kernel_dev’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  ret = do_mount(kernel_dev, kernel_dir->name, kernel_type, flags,
        ^
fs/namespace.c:2699:8: note: ‘kernel_dev’ was declared here
  char *kernel_dev;
        ^
fs/namespace.c:2720:8: warning: ‘kernel_type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  ret = do_mount(kernel_dev, kernel_dir->name, kernel_type, flags,
        ^
fs/namespace.c:2697:8: note: ‘kernel_type’ was declared here
  char *kernel_type;
        ^
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---

V1 - use of the uninitialized_var() macro rejected.
V2 - assign automatic variables an initial value.

 fs/namespace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index a01c773..365a06d 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2665,9 +2665,9 @@ SYSCALL_DEFINE5(mount, char __user *, dev_name, char __user *, dir_name,
 		char __user *, type, unsigned long, flags, void __user *, data)
 {
 	int ret;
-	char *kernel_type;
+	char *kernel_type = NULL;
 	struct filename *kernel_dir;
-	char *kernel_dev;
+	char *kernel_dev = NULL;
 	unsigned long data_page;
 
 	ret = copy_mount_string(type, &kernel_type);
-- 
2.1.0

  reply	other threads:[~2014-08-28 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 19:51 [PATCH 3.17-rc2] fs: namespace: suppress 'may be used uninitialized' warnings rtg.canonical
2014-08-27 21:01 ` Al Viro
2014-08-28 13:55   ` rtg.canonical [this message]
2014-08-28 14:32     ` [PATCH v2] " Al Viro
2014-08-28 17:26       ` [PATCH v3] " rtg.canonical

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409234149-3485-1-git-send-email-tim.gardner@canonical.com \
    --to=rtg.canonical@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.gardner@canonical.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).