From mboxrd@z Thu Jan 1 00:00:00 1970 From: rtg.canonical@gmail.com Subject: [PATCH v2] fs: namespace: suppress 'may be used uninitialized' warnings Date: Thu, 28 Aug 2014 07:55:49 -0600 Message-ID: <1409234149-3485-1-git-send-email-tim.gardner@canonical.com> References: <20140827210112.GE18016@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Tim Gardner , Alexander Viro To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <20140827210112.GE18016@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org =46rom: Tim Gardner The gcc version 4.9.1 compiler complains even though it isn't possible = for these variables to not get initialized before they are used. fs/namespace.c: In function =E2=80=98SyS_mount=E2=80=99: fs/namespace.c:2720:8: warning: =E2=80=98kernel_dev=E2=80=99 may be use= d uninitialized in this function [-Wmaybe-uninitialized] ret =3D do_mount(kernel_dev, kernel_dir->name, kernel_type, flags, ^ fs/namespace.c:2699:8: note: =E2=80=98kernel_dev=E2=80=99 was declared = here char *kernel_dev; ^ fs/namespace.c:2720:8: warning: =E2=80=98kernel_type=E2=80=99 may be us= ed uninitialized in this function [-Wmaybe-uninitialized] ret =3D do_mount(kernel_dev, kernel_dir->name, kernel_type, flags, ^ fs/namespace.c:2697:8: note: =E2=80=98kernel_type=E2=80=99 was declared= here char *kernel_type; ^ Cc: Alexander Viro Signed-off-by: Tim Gardner --- V1 - use of the uninitialized_var() macro rejected. V2 - assign automatic variables an initial value. fs/namespace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index a01c773..365a06d 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2665,9 +2665,9 @@ SYSCALL_DEFINE5(mount, char __user *, dev_name, c= har __user *, dir_name, char __user *, type, unsigned long, flags, void __user *, data) { int ret; - char *kernel_type; + char *kernel_type =3D NULL; struct filename *kernel_dir; - char *kernel_dev; + char *kernel_dev =3D NULL; unsigned long data_page; =20 ret =3D copy_mount_string(type, &kernel_type); --=20 2.1.0