From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Voytik Subject: [PATCH] fs: seq_file: optimize seq_pad() Date: Wed, 10 Sep 2014 13:20:19 +0400 Message-ID: <1410340819-18338-1-git-send-email-voytikd@gmail.com> Cc: Tetsuo Handa , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Dmitry Voytik To: Alexander Viro Return-path: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Use seq_putc() instead of seq_printf() in seq_pad() because the former is faster. Signed-off-by: Dmitry Voytik --- fs/seq_file.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/seq_file.c b/fs/seq_file.c index 3857b72..fef338e 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -787,8 +787,10 @@ EXPORT_SYMBOL(seq_write); void seq_pad(struct seq_file *m, char c) { int size = m->pad_until - m->count; - if (size > 0) - seq_printf(m, "%*s", size, ""); + + while (size-- > 0) + if (unlikely(seq_putc(m, ' '))) + return; if (c) seq_putc(m, c); } -- 1.9.1