From: Michal Hocko <mhocko@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-next@vger.kernel.org, sfr@canb.auug.org.au,
Sasha Levin <sasha.levin@oracle.com>
Subject: [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix.patch
Date: Tue, 23 Sep 2014 11:24:39 +0200 [thread overview]
Message-ID: <1411464279-20158-1-git-send-email-mhocko@suse.cz> (raw)
In-Reply-To: <5420b8b0.9HdYLyyuTikszzH8%akpm@linux-foundation.org>
dump_mm wants to dump mm->owner even when CONFIG_MEMCG is not defined
which leads to a compilation error:
mm/debug.c: In function ‘dump_mm’:
mm/debug.c:212:5: error: ‘const struct mm_struct’ has no member named ‘owner’
mm->owner, mm->exe_file,
Signed-off-by: Michal Hocko <mhocko@suse.cz>
---
mm/debug.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/mm/debug.c b/mm/debug.c
index 281abb2edddd..63aba9dcfb4e 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -181,7 +181,10 @@ void dump_mm(const struct mm_struct *mm)
#ifdef CONFIG_AIO
"ioctx_table %p\n"
#endif
- "owner %p exe_file %p\n"
+#ifdef CONFIG_MEMCG
+ "owner %p "
+#endif
+ "exe_file %p\n"
#ifdef CONFIG_MMU_NOTIFIER
"mmu_notifier_mm %p\n"
#endif
@@ -209,7 +212,10 @@ void dump_mm(const struct mm_struct *mm)
#ifdef CONFIG_AIO
mm->ioctx_table,
#endif
- mm->owner, mm->exe_file,
+#ifdef CONFIG_MEMCG
+ mm->owner,
+#endif
+ mm->exe_file,
#ifdef CONFIG_MMU_NOTIFIER
mm->mmu_notifier_mm,
#endif
--
2.1.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-23 9:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 0:02 mmotm 2014-09-22-16-57 uploaded akpm
2014-09-23 0:39 ` Stephen Rothwell
2014-09-23 1:12 ` Andrew Morton
2014-09-23 9:24 ` Michal Hocko [this message]
2014-09-23 11:28 ` [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix-fix.patch Michal Hocko
2014-09-23 16:19 ` Valdis.Kletnieks
2014-09-23 20:52 ` Andrew Morton
2014-09-24 7:09 ` Michal Hocko
2014-09-23 20:12 ` Dave Jones
2014-09-23 19:02 ` mmotm 2014-09-22-16-57 uploaded Guenter Roeck
2014-09-23 20:01 ` Andrew Morton
2014-09-23 20:13 ` Fabio Estevam
2014-09-23 20:20 ` Naoya Horiguchi
2014-09-23 20:38 ` Guenter Roeck
2014-09-23 21:08 ` Anish Bhatt
2014-09-23 20:31 ` Randy Dunlap
2014-09-23 20:57 ` Guenter Roeck
2014-09-23 21:36 ` Randy Dunlap
2014-09-23 21:53 ` Guenter Roeck
2014-09-24 4:34 ` Guenter Roeck
2014-09-24 6:24 ` David Miller
2014-09-24 7:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411464279-20158-1-git-send-email-mhocko@suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).