From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/7] seq_file: Rename static bool seq_overflow to public bool seq_is_full Date: Mon, 29 Sep 2014 16:48:15 -0700 Message-ID: <1412034495.4302.64.camel@joe-AO725> References: <20140929124246.3e39dac8@gandalf.local.home> <848ac7e3d1c31cddf638a8526fa3c59fa6fdeb8a.1412031505.git.joe@perches.com> <20140929194407.26832810@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Al Viro , Petr Mladek , Andrew Morton , Linus Torvalds , Jiri Kosina , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Steven Rostedt Return-path: In-Reply-To: <20140929194407.26832810@gandalf.local.home> Sender: linux-doc-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 2014-09-29 at 19:44 -0400, Steven Rostedt wrote: > On Mon, 29 Sep 2014 16:08:21 -0700 Joe Perches wrote: > > The return values of seq_printf/puts/putc are frequently misused. > > > > Start down a path to remove all the return value uses of these > > functions. [] > Actually, can you make a separate function that's public that is > seq_is_full(), where m->count >= m->size, and leave seq_overflow() > alone. Change the first patch to suit your taste. The rest of the series should not need change.