linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jan Kara <jack@suse.cz>, Theodore Ts'o <tytso@mit.edu>
Cc: kernel@pengutronix.de, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, linux-ext4@vger.kernel.org
Subject: [PATCH] vfs: fix compilation for no-MMU configurations
Date: Sun,  5 Oct 2014 10:58:36 +0200	[thread overview]
Message-ID: <1412499516-12839-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw)

Commit ac4dd23b76ce introduced a new function pagecache_isize_extended.
In <linux/mm.h> it was declared static inline and empty for no-MMU and
defined unconditionally in mm/truncate.c which results a compiler
error:

	  CC      mm/truncate.o
	mm/truncate.c:751:6: error: redefinition of 'pagecache_isize_extended'
	 void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
	      ^
	In file included from mm/truncate.c:13:0:
	include/linux/mm.h:1161:91: note: previous definition of 'pagecache_isize_extended' was here
	 static inline void pagecache_isize_extended(struct inode *inode, loff_t from,
												   ^
	scripts/Makefile.build:257: recipe for target 'mm/truncate.o' failed

(tested with ARCH=arm efm32_defconfig).

Fixes: ac4dd23b76ce ("vfs: fix data corruption when blocksize < pagesize for mmaped data")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

the bad commit sits in

git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git#dev

and is included in next.

Best regards
Uwe

 mm/truncate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/truncate.c b/mm/truncate.c
index 261eaf6e5a19..0d9c4ebd5ecc 100644
--- a/mm/truncate.c
+++ b/mm/truncate.c
@@ -729,6 +729,7 @@ void truncate_setsize(struct inode *inode, loff_t newsize)
 }
 EXPORT_SYMBOL(truncate_setsize);
 
+#ifdef CONFIG_MMU
 /**
  * pagecache_isize_extended - update pagecache after extension of i_size
  * @inode:	inode for which i_size was extended
@@ -780,6 +781,7 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
 	page_cache_release(page);
 }
 EXPORT_SYMBOL(pagecache_isize_extended);
+#endif
 
 /**
  * truncate_pagecache_range - unmap and remove pagecache that is hole-punched
-- 
2.1.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2014-10-05  8:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-05  8:58 Uwe Kleine-König [this message]
2014-10-06  9:25 ` [PATCH] vfs: fix compilation for no-MMU configurations Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412499516-12839-1-git-send-email-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=jack@suse.cz \
    --cc=kernel@pengutronix.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).