From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann Droneaud <ydroneaud@opteya.com>
Subject: Re: [PATCHv9 2/5] ppc/cell: trivial: replace get_unused_fd() by
 get_unused_fd_flags(0)
Date: Thu, 16 Oct 2014 11:10:24 +0200
Message-ID: <1413450624.17854.3.camel@localhost.localdomain>
References: <cover.1413223900.git.ydroneaud@opteya.com>
	 <9a145561123e28585d7994b61359a531128a80b8.1413223900.git.ydroneaud@opteya.com>
	 <1413251832.21120.4.camel@concordia>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Jeremy Kerr <jk@ozlabs.org>, Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Kosina <trivial@kernel.org>,
	linuxppc-dev@lists.ozlabs.org, cbe-oss-dev@lists.ozlabs.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yann Droneaud <ydroneaud@opteya.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1413251832.21120.4.camel@concordia>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Hi,

Le mardi 14 octobre 2014 =C3=A0 12:57 +1100, Michael Ellerman a =C3=A9c=
rit :
> On Mon, 2014-10-13 at 21:30 +0200, Yann Droneaud wrote:
> > This patch replaces calls to get_unused_fd() with equivalent call t=
o
> > get_unused_fd_flags(0) to preserve current behavor for existing cod=
e.
> >=20
> > In a further patch, get_unused_fd() will be removed so that new cod=
e
> > start using get_unused_fd_flags(), with the hope O_CLOEXEC could be
> > used, either by default or choosen by userspace.
> >=20
> > Link: http://lkml.kernel.org/r/cover.1413223900.git.ydroneaud@optey=
a.com
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: trivial@kernel.org
> > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
>=20
> This is fine by me, do you want an ack, or do you want us to take it =
via the
> powerpc tree?
>=20

The patch was added in -mm by Andrew, so I guess the patch will be
merged sooner or later.

Anyway, you could investigate to check if O_CLOEXEC could be used
instead of 0 in call to get_unused_fd_flags().

> If the former:
>=20
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>=20

Thanks a lot.

Regards.

--=20
Yann Droneaud
OPTEYA