From: Richard Weinberger <richard@nod.at>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: [PATCH 1/2] fat: Fix d_splice_alias() return code checking
Date: Sun, 19 Oct 2014 12:39:43 +0200 [thread overview]
Message-ID: <1413715184-30196-1-git-send-email-richard@nod.at> (raw)
d_splice_alias() can return a valid dentry, NULL or an ERR_PTR.
Currently the code checks not for ERR_PTR.
Fix this by using IS_ERR_OR_NULL().
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
fs/fat/namei_vfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index 6df8d3d..8f93464 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -757,7 +757,7 @@ out:
mutex_unlock(&MSDOS_SB(sb)->s_lock);
dentry->d_time = dentry->d_parent->d_inode->i_version;
dentry = d_splice_alias(inode, dentry);
- if (dentry)
+ if (!IS_ERR_OR_NULL(dentry))
dentry->d_time = dentry->d_parent->d_inode->i_version;
return dentry;
--
2.1.0
next reply other threads:[~2014-10-19 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 10:39 Richard Weinberger [this message]
2014-10-19 10:39 ` [PATCH 2/2] ocfs2: Fix d_splice_alias() return code checking Richard Weinberger
2014-10-20 23:12 ` [Ocfs2-devel] " Andrew Morton
2014-10-22 20:33 ` Richard Weinberger
2014-10-20 12:34 ` [PATCH 1/2] fat: " Al Viro
2014-10-23 15:21 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413715184-30196-1-git-send-email-richard@nod.at \
--to=richard@nod.at \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).