From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH] seq_file: Remove pointless assignment in seq_read() Date: Tue, 21 Oct 2014 17:12:03 +0200 Message-ID: <1413904323-19043-1-git-send-email-jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, Jan Kara To: Alexander Viro Return-path: Received: from cantor2.suse.de ([195.135.220.15]:51978 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754662AbaJUPMH (ORCPT ); Tue, 21 Oct 2014 11:12:07 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The value assigned to 'err' in seq_read() is overwritten by the result of copy_to_user(). This is correct because we know we have succeeded to generate at least one entry into user buffer so the error we got when generating further entries is irrelevant. Just remove the assignment. Coverity-id: 1226981 Signed-off-by: Jan Kara --- fs/seq_file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/seq_file.c b/fs/seq_file.c index 3857b720cb1b..cf53252e4784 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -262,10 +262,8 @@ Fill: size_t offs = m->count; loff_t next = pos; p = m->op->next(m, p, &next); - if (!p || IS_ERR(p)) { - err = PTR_ERR(p); + if (!p || IS_ERR(p)) break; - } err = m->op->show(m, p); if (seq_overflow(m) || err) { m->count = offs; -- 1.8.1.4