* [PATCH] ncpfs: Return proper error from NCP_IOC_SETROOT ioctl
@ 2014-10-22 6:42 Jan Kara
0 siblings, 0 replies; only message in thread
From: Jan Kara @ 2014-10-22 6:42 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-fsdevel, Petr Vandrovec, Jan Kara, stable
If some error happens in NCP_IOC_SETROOT ioctl, the appropriate error
return value is then (in most cases) just overwritten before we return.
This can result in reporting success to userspace although error
happened. This bug was introduced by commit 2e54eb96e2c8 (BKL: Remove
BKL from ncpfs). Propagate the errors correctly.
Coverity-id: 1226925
CC: stable@vger.kernel.org
Fixes: 2e54eb96e2c801f33d95b5dade15212ac4d6c4a5
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ncpfs/ioctl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ncpfs/ioctl.c b/fs/ncpfs/ioctl.c
index d5659d96ee7f..cf7e043a9447 100644
--- a/fs/ncpfs/ioctl.c
+++ b/fs/ncpfs/ioctl.c
@@ -447,7 +447,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
result = -EIO;
}
}
- result = 0;
}
mutex_unlock(&server->root_setup_lock);
--
1.8.1.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-10-22 6:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-22 6:42 [PATCH] ncpfs: Return proper error from NCP_IOC_SETROOT ioctl Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).