From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH RESEND] mm: Remove false WARN_ON from pagecache_isize_extended() Date: Mon, 27 Oct 2014 10:58:05 +0100 Message-ID: <1414403885-16219-1-git-send-email-jack@suse.cz> Cc: Dave Chinner , linux-fsdevel@vger.kernel.org, Jan Kara To: Ted Tso Return-path: Received: from cantor2.suse.de ([195.135.220.15]:48505 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbaJ0J6G (ORCPT ); Mon, 27 Oct 2014 05:58:06 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The WARN_ON checking whether i_mutex is held in pagecache_isize_extended() was wrong because some filesystems (e.g. XFS) use different locks for serialization of truncates / writes. So just remove the check. Signed-off-by: Jan Kara --- mm/truncate.c | 1 - 1 file changed, 1 deletion(-) Ted can you please merge this patch? I originally sent this patch in a reply to Fengguangs report and apparently you missed it. Thanks! diff --git a/mm/truncate.c b/mm/truncate.c index 261eaf6e5a19..c646084e5eec 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -755,7 +755,6 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to) struct page *page; pgoff_t index; - WARN_ON(!mutex_is_locked(&inode->i_mutex)); WARN_ON(to > inode->i_size); if (from >= to || bsize == PAGE_CACHE_SIZE) -- 1.8.1.4