From: Ewan Milne <emilne@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-fsdevel@vger.kernel.org, neilb@suse.de
Subject: Re: [RFC] Discard update for 3.19
Date: Wed, 12 Nov 2014 13:40:15 -0500 [thread overview]
Message-ID: <1415817615.16672.49.camel@localhost.localdomain> (raw)
In-Reply-To: <20141110141906.GA20891@infradead.org>
On Mon, 2014-11-10 at 06:19 -0800, Christoph Hellwig wrote:
> Looks like there is no real dependency between these patches, so we
> might take on each through the libata, scsi and block trees.
>
> Can I get another review for the sd patch, please?
>
The changes in [PATCH 2/3] sd: Disable discard_zeroes_data for UNMAP
look fine to me. I was wondering, though, if the changes to add the
"devices_handle_discard_safely" module parameter to the MD raid drivers
are really needed if this is fixed. (It's great to be able to disable
the use of discard if desired, but how is an administrator actually
supposed to know if the devices they have *really* work properly?)
Maybe the default value of this parameter should be changed, or the
parameter should be changed to have an inverse sense, i.e. "disable
use of discard"...
-Ewan
next prev parent reply other threads:[~2014-11-12 18:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 5:08 [RFC] Discard update for 3.19 Martin K. Petersen
2014-11-07 5:08 ` [PATCH 1/3] libata: Whitelist SSDs that are known to properly return zeroes after TRIM Martin K. Petersen
2014-11-07 8:24 ` Christoph Hellwig
2014-11-07 15:37 ` Martin K. Petersen
2014-12-05 16:45 ` Paolo Bonzini
2014-12-05 22:58 ` Elliott, Robert (Server Storage)
2014-12-08 15:15 ` Theodore Ts'o
2014-12-08 15:28 ` James Bottomley
2014-12-08 22:59 ` One Thousand Gnomes
2014-11-07 5:08 ` [PATCH 2/3] sd: Disable discard_zeroes_data for UNMAP Martin K. Petersen
2014-11-07 8:25 ` Christoph Hellwig
2014-11-10 23:43 ` Paolo Bonzini
2014-11-07 5:08 ` [PATCH 3/3] block: Introduce blkdev_issue_zeroout_discard() function Martin K. Petersen
2014-11-07 8:26 ` Christoph Hellwig
2014-11-07 15:42 ` Martin K. Petersen
2014-11-07 16:20 ` Theodore Ts'o
2014-11-07 16:27 ` Martin K. Petersen
2014-11-14 20:22 ` Martin K. Petersen
2014-11-17 18:53 ` Darrick J. Wong
2014-11-11 0:04 ` Darrick J. Wong
2014-11-11 2:33 ` Martin K. Petersen
2014-11-17 19:28 ` [PATCH] block: create ioctl to discard-or-zeroout a range of blocks Darrick J. Wong
2014-11-07 12:09 ` [RFC] Discard update for 3.19 Bernd Schubert
2014-11-07 12:11 ` Bernd Schubert
2014-11-07 15:46 ` Martin K. Petersen
2014-11-10 14:19 ` Christoph Hellwig
2014-11-12 18:40 ` Ewan Milne [this message]
2014-11-12 19:41 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415817615.16672.49.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).