From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 1/2] f2fs: fix to call put_page at the error handling routine
Date: Mon, 17 Nov 2014 17:57:53 -0800 [thread overview]
Message-ID: <1416275874-74186-1-git-send-email-jaegeuk@kernel.org> (raw)
The locked page should be released before returning the function.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/inline.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 053d114..f26fb87 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -141,8 +141,8 @@ int f2fs_convert_inline_inode(struct inode *inode)
ipage = get_node_page(sbi, inode->i_ino);
if (IS_ERR(ipage)) {
- f2fs_unlock_op(sbi);
- return PTR_ERR(ipage);
+ err = PTR_ERR(ipage);
+ goto out;
}
set_new_dnode(&dn, inode, ipage, ipage, 0);
@@ -151,7 +151,7 @@ int f2fs_convert_inline_inode(struct inode *inode)
err = f2fs_convert_inline_page(&dn, page);
f2fs_put_dnode(&dn);
-
+out:
f2fs_unlock_op(sbi);
f2fs_put_page(page, 1);
--
2.1.1
next reply other threads:[~2014-11-18 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 1:57 Jaegeuk Kim [this message]
2014-11-18 1:57 ` [PATCH 2/2] f2fs: put the inode page when error was occurred Jaegeuk Kim
2014-11-18 5:30 ` [f2fs-dev] " Chao Yu
2014-11-19 22:33 ` Jaegeuk Kim
2014-11-18 5:22 ` [f2fs-dev] [PATCH 1/2] f2fs: fix to call put_page at the error handling routine Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416275874-74186-1-git-send-email-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).