From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: [PATCH 2/5] fs: Fix WARN_ON in inode_set_mask() Date: Thu, 4 Dec 2014 14:27:36 +0100 Message-ID: <1417699659-14284-3-git-send-email-jack@suse.cz> References: <1417699659-14284-1-git-send-email-jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, linux-security-module@vger.kernel.org, Jan Kara To: Al Viro Return-path: Received: from cantor2.suse.de ([195.135.220.15]:52838 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbaLDN1x (ORCPT ); Thu, 4 Dec 2014 08:27:53 -0500 In-Reply-To: <1417699659-14284-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: WARN_ON in inode_set_mask() warns if we don't clear all bits we are setting instead of reverse - warning when caller requests setting and clearing of the same bit. Signed-off-by: Jan Kara --- fs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/inode.c b/fs/inode.c index fcc0886c5824..3490389dc813 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1923,7 +1923,7 @@ void inode_set_flags(struct inode *inode, unsigned int flags, { unsigned int old_flags, new_flags; - WARN_ON_ONCE(flags & ~mask); + WARN_ON_ONCE(flags & mask); do { old_flags = ACCESS_ONCE(inode->i_flags); new_flags = (old_flags & ~mask) | flags; -- 1.8.1.4