From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: [PATCH] xfstests: generic/315: make sure the test file exists and is zero length Date: Wed, 10 Dec 2014 22:13:43 -0500 Message-ID: <1418267623-29612-1-git-send-email-tytso@mit.edu> Cc: Theodore Ts'o To: Linux Filesystem Development List Return-path: Received: from imap.thunk.org ([74.207.234.97]:50530 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933176AbaLKDNr (ORCPT ); Wed, 10 Dec 2014 22:13:47 -0500 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Before we determine how much space is available to be fallocated, and before trying to fallocate the file, we need to make sure testfile.315 exists and is zero-length. Otherwise the fallocate program will fail the first time generic/315 is run on a freshly mkfs'ed file system: generic/315 0s ... [06:31:43] [06:31:44] [failed, exit status 1] - output mismatch (see /results/results-ext3conv/generic/315.out.bad) --- tests/generic/315.out 2014-10-31 10:13:04.000000000 -0400 +++ /results/results-ext3conv/generic/315.out.bad 2014-11-24 06:31:44.111279060 -0500 @@ -1,2 +1,6 @@ QA output created by 315 Slience is golden +ls: cannot access /vdd/testfile.315: No such file or directory +./tests/generic/315: line 69: [: : integer expression expected +File size is changed to ( Bytes) +(see /results/results-ext3conv/generic/315.full for details) ... (Run 'diff -u tests/generic/315.out /results/results-ext3conv/generic/315.out.bad' to see the entire diff) (You can also reproduce the above failure if you delete testfile.315 before running generic/315.) This commit fixes this issue. Signed-off-by: Theodore Ts'o --- tests/generic/315 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/generic/315 b/tests/generic/315 index 62fdc01..ad71fe6 100755 --- a/tests/generic/315 +++ b/tests/generic/315 @@ -54,6 +54,8 @@ rm -f $seqres.full echo "Slience is golden" +cp /dev/null $TEST_DIR/testfile.$seq + # Check the current avaliable disk space on $TEST_DIR. # 1024KiB at least avail_begin=`df -P $TEST_DIR | awk 'END {print $4}'` -- 2.1.0