From: Josef Bacik <jbacik@fb.com>
To: <viro@ZenIV.linux.org.uk>, <linux-fsdevel@vger.kernel.org>
Subject: [PATCH v2] vfs: don't softlockup when evicting inodes
Date: Fri, 19 Dec 2014 10:34:40 -0500 [thread overview]
Message-ID: <1419003280-14401-1-git-send-email-jbacik@fb.com> (raw)
If I run an fs_mark job that creates millions of empty files and then
immediately unmount the file system I will get a softlockup during unmount.
This box has ~140gb of RAM so we never hit sufficient memory pressure to evict
enough inodes during the runtime of the benchmark, which means I see around 80
million inodes being evicted at unmount time. With this patch my box no longer
softlocks up. Thanks,
Signed-off-by: Josef Bacik <jbacik@fb.com>
---
V1->V2:
-Still occasionally saw a softlockup in evict_inodes so add a cond_resched_lock
to that case as well.
fs/inode.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/inode.c b/fs/inode.c
index ad60555..f266765 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -581,6 +581,7 @@ static void dispose_list(struct list_head *head)
list_del_init(&inode->i_lru);
evict(inode);
+ cond_resched();
}
}
@@ -613,6 +614,7 @@ void evict_inodes(struct super_block *sb)
inode_lru_list_del(inode);
spin_unlock(&inode->i_lock);
list_add(&inode->i_lru, &dispose);
+ cond_resched_lock(&inode_sb_list_lock);
}
spin_unlock(&inode_sb_list_lock);
--
1.9.3
next reply other threads:[~2014-12-19 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 15:34 Josef Bacik [this message]
2014-12-21 12:18 ` [PATCH v2] vfs: don't softlockup when evicting inodes Jeff Layton
2014-12-21 12:25 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419003280-14401-1-git-send-email-jbacik@fb.com \
--to=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).