From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [PATCH RFC] fs/aio: fix sleeping while TASK_INTERRUPTIBLE Date: Tue, 13 Jan 2015 11:20:20 -0500 Message-ID: <1421166020.21014.7@mail.thefacebook.com> References: <20141223001619.GA26385@ret.masoncoding.com> <20150113160633.GC25742@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Cc: , , Peter Zijlstra To: Benjamin LaHaise Return-path: In-Reply-To: <20150113160633.GC25742@kvack.org> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jan 13, 2015 at 11:06 AM, Benjamin LaHaise wrote: > Hi Chris, > > On Mon, Dec 22, 2014 at 07:16:25PM -0500, Chris Mason wrote: >> The 3.19 merge window brought in a great new warning to catch >> someone >> calling might_sleep with their state != TASK_RUNNING. The idea was >> to >> find buggy code locking mutexes after calling prepare_to_wait(), >> kind >> of like this: > ... >> This has been lightly tested and hasn't been benchmarked, so RFC for >> now. >> >> Signed-off-by: Chris Mason >> Reported-by: The code of Peter Zijlstra > > After mulling this over, I think your patch is probably the safest > for us > to apply at present as it is also the most amenable to backporting. > Are > you okay with removing the RFC status? I still have my concerns about > possible task wakeups causing problems with filesystem code if the > copy_to_user() takes a page fault, but those can be addressed > separately. > Kent's closures are an option for the future, but I think it would be > more appropriate for that new code to be introduced in the next merge > window. I'll resend the patch with improved comments, and get perf tests done on fast storage. -chris -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org