From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: [PATCH RESEND] fs: namei: Use memcpy instead of strlcpy Date: Wed, 21 Jan 2015 14:44:25 -0800 Message-ID: <1421880265-26647-1-git-send-email-linux@roeck-us.net> Cc: Sabrina Dubroca , Paul Moore , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck To: Alexander Viro Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:32958 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbbAUWpH (ORCPT ); Wed, 21 Jan 2015 17:45:07 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YE41L-000t5w-Eq for linux-fsdevel@vger.kernel.org; Wed, 21 Jan 2015 22:45:07 +0000 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: If the string length is known, there is no need to use strlcpy. Use memcpy instead. Signed-off-by: Guenter Roeck --- Nitpick, but still a bit faster. Applies on top of -next. Resending with correct cc:. Sorry for the noise. fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index 323957f..2e09219 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -233,7 +233,7 @@ getname_kernel(const char * filename) __putname(result); return ERR_PTR(-ENAMETOOLONG); } - strlcpy((char *)result->name, filename, len); + memcpy((char *)result->name, filename, len); result->uptr = NULL; result->aname = NULL; result->refcnt = 1; -- 2.1.0