From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fs: Use strchrnul in get_fs_type
Date: Fri, 30 Jan 2015 14:26:13 +0100 [thread overview]
Message-ID: <1422624373-16617-1-git-send-email-linux@rasmusvillemoes.dk> (raw)
Using strchrnul yields smaller code and avoids extra strlen call.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
fs/filesystems.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/filesystems.c b/fs/filesystems.c
index 5797d45a78cb..d56a7bb09afa 100644
--- a/fs/filesystems.c
+++ b/fs/filesystems.c
@@ -271,14 +271,14 @@ static struct file_system_type *__get_fs_type(const char *name, int len)
struct file_system_type *get_fs_type(const char *name)
{
struct file_system_type *fs;
- const char *dot = strchr(name, '.');
- int len = dot ? dot - name : strlen(name);
+ const char *dot = strchrnul(name, '.');
+ int len = dot - name;
fs = __get_fs_type(name, len);
if (!fs && (request_module("fs-%.*s", len, name) == 0))
fs = __get_fs_type(name, len);
- if (dot && fs && !(fs->fs_flags & FS_HAS_SUBTYPE)) {
+ if (*dot && fs && !(fs->fs_flags & FS_HAS_SUBTYPE)) {
put_filesystem(fs);
fs = NULL;
}
--
2.1.3
reply other threads:[~2015-01-30 13:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422624373-16617-1-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).