* [PATCH] fs: Use strchrnul in get_fs_type
@ 2015-01-30 13:26 Rasmus Villemoes
0 siblings, 0 replies; only message in thread
From: Rasmus Villemoes @ 2015-01-30 13:26 UTC (permalink / raw)
To: Alexander Viro; +Cc: Rasmus Villemoes, linux-fsdevel, linux-kernel
Using strchrnul yields smaller code and avoids extra strlen call.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
fs/filesystems.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/filesystems.c b/fs/filesystems.c
index 5797d45a78cb..d56a7bb09afa 100644
--- a/fs/filesystems.c
+++ b/fs/filesystems.c
@@ -271,14 +271,14 @@ static struct file_system_type *__get_fs_type(const char *name, int len)
struct file_system_type *get_fs_type(const char *name)
{
struct file_system_type *fs;
- const char *dot = strchr(name, '.');
- int len = dot ? dot - name : strlen(name);
+ const char *dot = strchrnul(name, '.');
+ int len = dot - name;
fs = __get_fs_type(name, len);
if (!fs && (request_module("fs-%.*s", len, name) == 0))
fs = __get_fs_type(name, len);
- if (dot && fs && !(fs->fs_flags & FS_HAS_SUBTYPE)) {
+ if (*dot && fs && !(fs->fs_flags & FS_HAS_SUBTYPE)) {
put_filesystem(fs);
fs = NULL;
}
--
2.1.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-01-30 13:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-30 13:26 [PATCH] fs: Use strchrnul in get_fs_type Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).