* [PATCH 1/1] export symbol kobject_move()
@ 2015-02-08 23:48 Anand Jain
2015-02-11 23:03 ` [PATCH 1/1 V2] " Anand Jain
0 siblings, 1 reply; 4+ messages in thread
From: Anand Jain @ 2015-02-08 23:48 UTC (permalink / raw)
To: linux-fsdevel; +Cc: linux-btrfs, clm, dsterba
drivers/cpufreq/cpufreq.c is already using this function. And now btrfs
needs it as well. export symbol kobject_move().
---
lib/kobject.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/kobject.c b/lib/kobject.c
index 58751bb..e055c06 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -548,6 +548,7 @@ out:
kfree(devpath);
return error;
}
+EXPORT_SYMBOL_GPL(kobject_move);
/**
* kobject_del - unlink kobject from hierarchy.
--
2.0.0.153.g79dcccc
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1 V2] export symbol kobject_move()
2015-02-08 23:48 [PATCH 1/1] export symbol kobject_move() Anand Jain
@ 2015-02-11 23:03 ` Anand Jain
2015-02-12 9:53 ` David Sterba
0 siblings, 1 reply; 4+ messages in thread
From: Anand Jain @ 2015-02-11 23:03 UTC (permalink / raw)
To: linux-fsdevel; +Cc: linux-btrfs, clm, dsterba
drivers/cpufreq/cpufreq.c is already using this function. And now btrfs
needs it as well. export symbol kobject_move().
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v1->v2: Didn't notice there wasn't my signed-off, now added. Thanks Dave.
lib/kobject.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/kobject.c b/lib/kobject.c
index 58751bb..e055c06 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -548,6 +548,7 @@ out:
kfree(devpath);
return error;
}
+EXPORT_SYMBOL_GPL(kobject_move);
/**
* kobject_del - unlink kobject from hierarchy.
--
2.0.0.153.g79dcccc
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1 V2] export symbol kobject_move()
2015-02-11 23:03 ` [PATCH 1/1 V2] " Anand Jain
@ 2015-02-12 9:53 ` David Sterba
2015-02-12 10:47 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: David Sterba @ 2015-02-12 9:53 UTC (permalink / raw)
To: Anand Jain; +Cc: linux-fsdevel, linux-btrfs, clm, gregkh
Adding Greg to CC.
On Thu, Feb 12, 2015 at 07:03:37AM +0800, Anand Jain wrote:
> drivers/cpufreq/cpufreq.c is already using this function. And now btrfs
> needs it as well. export symbol kobject_move().
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v1->v2: Didn't notice there wasn't my signed-off, now added. Thanks Dave.
>
> lib/kobject.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 58751bb..e055c06 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -548,6 +548,7 @@ out:
> kfree(devpath);
> return error;
> }
> +EXPORT_SYMBOL_GPL(kobject_move);
Looks ok to me. There's another user of this function in
drivers/cpufreq/cpufreq.c, but apparenly not a module so the export was
not needed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1 V2] export symbol kobject_move()
2015-02-12 9:53 ` David Sterba
@ 2015-02-12 10:47 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-02-12 10:47 UTC (permalink / raw)
To: dsterba, Anand Jain, linux-fsdevel, linux-btrfs, clm
On Thu, Feb 12, 2015 at 10:53:14AM +0100, David Sterba wrote:
> Adding Greg to CC.
>
> On Thu, Feb 12, 2015 at 07:03:37AM +0800, Anand Jain wrote:
> > drivers/cpufreq/cpufreq.c is already using this function. And now btrfs
> > needs it as well. export symbol kobject_move().
> >
> > Signed-off-by: Anand Jain <anand.jain@oracle.com>
> > ---
> > v1->v2: Didn't notice there wasn't my signed-off, now added. Thanks Dave.
> >
> > lib/kobject.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/kobject.c b/lib/kobject.c
> > index 58751bb..e055c06 100644
> > --- a/lib/kobject.c
> > +++ b/lib/kobject.c
> > @@ -548,6 +548,7 @@ out:
> > kfree(devpath);
> > return error;
> > }
> > +EXPORT_SYMBOL_GPL(kobject_move);
>
> Looks ok to me. There's another user of this function in
> drivers/cpufreq/cpufreq.c, but apparenly not a module so the export was
> not needed.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-12 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 23:48 [PATCH 1/1] export symbol kobject_move() Anand Jain
2015-02-11 23:03 ` [PATCH 1/1 V2] " Anand Jain
2015-02-12 9:53 ` David Sterba
2015-02-12 10:47 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).