From: Viacheslav Dubeyko <slava@dubeyko.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Sougata Santra <sougata@tuxera.com>,
Sergei Antonov <saproj@gmail.com>, Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] hfsplus: add missing curly braces in hfsplus_delete_cat()
Date: Wed, 25 Feb 2015 09:42:54 -0800 [thread overview]
Message-ID: <1424886174.2803.0.camel@slavad-ubuntu-14.04> (raw)
In-Reply-To: <20150225133644.GW19745@mwanda>
On Wed, 2015-02-25 at 16:36 +0300, Dan Carpenter wrote:
> This doesn't change how the code works, but clearly the curly braces
> were intended.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good for me.
Thanks,
Vyacheslav Dubeyko.
>
> diff --git a/fs/hfsplus/catalog.c b/fs/hfsplus/catalog.c
> index 7892e6f..022974a 100644
> --- a/fs/hfsplus/catalog.c
> +++ b/fs/hfsplus/catalog.c
> @@ -350,10 +350,11 @@ int hfsplus_delete_cat(u32 cnid, struct inode *dir, struct qstr *str)
> &fd.search_key->cat.name.unicode,
> off + 2, len);
> fd.search_key->key_len = cpu_to_be16(6 + len);
> - } else
> + } else {
> err = hfsplus_cat_build_key(sb, fd.search_key, dir->i_ino, str);
> if (unlikely(err))
> goto out;
> + }
>
> err = hfs_brec_find(&fd, hfs_find_rec_by_key);
> if (err)
prev parent reply other threads:[~2015-02-25 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:36 [patch] hfsplus: add missing curly braces in hfsplus_delete_cat() Dan Carpenter
2015-02-25 14:50 ` Sergei Antonov
2015-02-25 17:13 ` Dan Carpenter
2015-02-25 18:20 ` Sergei Antonov
2015-02-25 18:30 ` Dan Carpenter
2015-02-25 18:37 ` Sergei Antonov
2015-02-25 18:50 ` Dan Carpenter
2015-02-25 17:42 ` Viacheslav Dubeyko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424886174.2803.0.camel@slavad-ubuntu-14.04 \
--to=slava@dubeyko.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=saproj@gmail.com \
--cc=sougata@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).