From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viacheslav Dubeyko Subject: Re: [PATCH 1/1] hfs: incorrect return values Date: Wed, 25 Mar 2015 09:54:42 -0700 Message-ID: <1427302482.2888.7.camel@slavad-ubuntu-14.04> References: <1427243843-25929-1-git-send-email-csong84@gatech.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu To: Chengyu Song Return-path: In-Reply-To: <1427243843-25929-1-git-send-email-csong84@gatech.edu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2015-03-24 at 20:37 -0400, Chengyu Song wrote: > In case of memory allocation error, the return should be -ENOMEM, > instead of -ENOSPC. > To be honest, I am not fully sure that such fix makes sense. Of course, it is possible to exchange -ENOSPC on -ENOMEM. But principally it is not critical to use as -ENOSPC as -ENOMEM in such situation, from my point of view. Anyway, it is possible to change error code here. Thanks, Vyacheslav Dubeyko.