From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH 3/5 v2] lightnvm: RRPC target
Date: Thu, 16 Apr 2015 11:12:39 +0200
Message-ID: <1429175559.16771.47.camel@x220>
References: <1429101284-19490-1-git-send-email-m@bjorling.me>
	 <1429101284-19490-4-git-send-email-m@bjorling.me>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	javier@paletta.io, keith.busch@intel.com
To: Matias =?ISO-8859-1?Q?Bj=F8rling?= <m@bjorling.me>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1429101284-19490-4-git-send-email-m@bjorling.me>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, 2015-04-15 at 14:34 +0200, Matias Bj=C3=B8rling wrote:
> --- /dev/null
> +++ b/drivers/lightnvm/Kconfig

> +menuconfig NVM
> +	bool "Open-Channel SSD target support"
> +	depends on BLK_DEV_NVM
> +	help
> +	  Say Y here to get to enable Open-channel SSDs.
> +
> +	  Open-Channel SSDs implement a set of extension to SSDs, that
> +	  exposes direct access to the underlying non-volatile memory.
> +
> +	  If you say N, all options in this submenu will be skipped and dis=
abled
> +	  only do this if you know what you are doing.
> +
> +if NVM
> +
> +config NVM_RRPC
> +	tristate "Round-robin Hybrid Open-Channel SSD"
> +	depends on BLK_DEV_NVM

NVM implies BLK_DEV_NVM so this dependency isn't really needed.

> +	---help---
> +	Allows an open-channel SSD to be exposed as a block device to the
> +	host. The target is implemented using a linear mapping table and
> +	cost-based garbage collection. It is optimized for 4K IO sizes.
> +
> +	See Documentation/nvm-rrpc.txt for details.

This file isn't part of this series, is it?

> +
> +endif # NVM
> diff --git a/drivers/lightnvm/Makefile b/drivers/lightnvm/Makefile
> new file mode 100644
> index 0000000..80d75a8
> --- /dev/null
> +++ b/drivers/lightnvm/Makefile
> @@ -0,0 +1,5 @@
> +#
> +# Makefile for Open-Channel SSDs.
> +#
> +
> +obj-$(CONFIG_NVM)		+=3D rrpc.o

I suppose you meant to use
    obj-$(CONFIG_NVM_RRPC)		+=3D rrpc.o

because otherwise setting NVM_RRPC has no effect.=20

> --- /dev/null
> +++ b/drivers/lightnvm/rrpc.c

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License versi=
on
> + * 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, b=
ut
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

And (according to include/linux/module.h) the license ident "GPL" state=
s
the license is GPL v2 or later. So either the comment at the top of thi=
s
file or the license ident needs to change.

Thanks,


Paul Bolle