From mboxrd@z Thu Jan 1 00:00:00 1970 From: Firo Yang Subject: [PATCH] fs/compat: remove redundant 'less than zero' check Date: Fri, 24 Apr 2015 18:07:50 +0800 Message-ID: <1429870070-30310-1-git-send-email-firogm@gmail.com> Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org, Firo Yang To: viro@zeniv.linux.org.uk Return-path: Sender: kernel-janitors-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Smatch complains about the check in compat.c. fs/compat.c:565 compat_rw_copy_check_uvector() warn: unsigned 'nr_segs' is never less than zero. I think, there is no reason to check if the value nr_segs is less than zero. So I removed it. Signed-off-by: Firo Yang --- fs/compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/compat.c b/fs/compat.c index 6fd272d..beaf15b 100644 --- a/fs/compat.c +++ b/fs/compat.c @@ -562,7 +562,7 @@ ssize_t compat_rw_copy_check_uvector(int type, goto out; ret = -EINVAL; - if (nr_segs > UIO_MAXIOV || nr_segs < 0) + if (nr_segs > UIO_MAXIOV) goto out; if (nr_segs > fast_segs) { ret = -ENOMEM; -- 2.1.0