From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Copeland Subject: [PATCH 2/4] omfs: set error return when d_make_root() fails Date: Mon, 18 May 2015 07:34:36 -0400 Message-ID: <1431948878-3756-3-git-send-email-me@bobcopeland.com> References: <1431948878-3756-1-git-send-email-me@bobcopeland.com> Cc: linux-fsdevel@vger.kernel.org, Bob Copeland To: akpm@linux-foundation.org Return-path: Received: from mail-ig0-f175.google.com ([209.85.213.175]:38770 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753768AbbERLha (ORCPT ); Mon, 18 May 2015 07:37:30 -0400 Received: by igcau1 with SMTP id au1so44724347igc.1 for ; Mon, 18 May 2015 04:37:29 -0700 (PDT) In-Reply-To: <1431948878-3756-1-git-send-email-me@bobcopeland.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: A static checker found the following issue in the error path for omfs_fill_super: fs/omfs/inode.c:552 omfs_fill_super() warn: missing error code here? 'd_make_root()' failed. 'ret' = '0' Fix by returning -ENOMEM in this case. Reported-by: Dan Carpenter Signed-off-by: Bob Copeland --- fs/omfs/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index 70d4191cf33d..6ce542c11f98 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c @@ -549,8 +549,10 @@ static int omfs_fill_super(struct super_block *sb, void *data, int silent) } sb->s_root = d_make_root(root); - if (!sb->s_root) + if (!sb->s_root) { + ret = -ENOMEM; goto out_brelse_bh2; + } printk(KERN_DEBUG "omfs: Mounted volume %s\n", omfs_rb->r_name); ret = 0; -- 2.1.4