linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	lizefan@huawei.com, cgroups@vger.kernel.org, hannes@cmpxchg.org,
	kernel-team@fb.com, tytso@mit.edu, adilger.kernel@dilger.ca,
	linux-ext4@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc
Date: Tue, 16 Jun 2015 18:53:12 -0400	[thread overview]
Message-ID: <1434495193-31182-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1434495193-31182-1-git-send-email-tj@kernel.org>

ext4_io_submit_init() takes the pointer to writeback_control to test
its sync_mode and determine between WRITE and WRITE_SYNC and records
the result in ->io_op.  This patch makes it record the pointer
directly and moves the test to ext4_io_submit().

This doesn't cause any noticeable differences now but having
writeback_control available throughout IO submission path will be
depended upon by the planned cgroup writeback support.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: linux-ext4@vger.kernel.org
---
 fs/ext4/ext4.h    | 2 +-
 fs/ext4/page-io.c | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 009a059..74a4923 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -191,7 +191,7 @@ typedef struct ext4_io_end {
 } ext4_io_end_t;
 
 struct ext4_io_submit {
-	int			io_op;
+	struct writeback_control *io_wbc;
 	struct bio		*io_bio;
 	ext4_io_end_t		*io_end;
 	sector_t		io_next_block;
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index c5d81e8..3f80cb2 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -357,8 +357,10 @@ void ext4_io_submit(struct ext4_io_submit *io)
 	struct bio *bio = io->io_bio;
 
 	if (bio) {
+		int io_op = io->io_wbc->sync_mode == WB_SYNC_ALL ?
+			    WRITE_SYNC : WRITE;
 		bio_get(io->io_bio);
-		submit_bio(io->io_op, io->io_bio);
+		submit_bio(io_op, io->io_bio);
 		bio_put(io->io_bio);
 	}
 	io->io_bio = NULL;
@@ -367,7 +369,7 @@ void ext4_io_submit(struct ext4_io_submit *io)
 void ext4_io_submit_init(struct ext4_io_submit *io,
 			 struct writeback_control *wbc)
 {
-	io->io_op = (wbc->sync_mode == WB_SYNC_ALL ?  WRITE_SYNC : WRITE);
+	io->io_wbc = wbc;
 	io->io_bio = NULL;
 	io->io_end = NULL;
 }
-- 
2.4.3

  reply	other threads:[~2015-06-16 22:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 22:53 [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-06-16 22:53 ` Tejun Heo [this message]
     [not found]   ` <1434495193-31182-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-07-22  3:56     ` [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc Theodore Ts'o
2015-06-16 22:53 ` [PATCH 2/2] ext4: implement cgroup writeback support Tejun Heo
     [not found]   ` <1434495193-31182-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-07-22  3:56     ` Theodore Ts'o
2015-09-23 12:49       ` Artem Bityutskiy
2015-09-23 13:50         ` Artem Bityutskiy
2015-09-23 17:02           ` Theodore Ts'o
2015-09-23 17:57             ` Tejun Heo
2015-09-23 17:25         ` Chris Mason
     [not found]           ` <CAF4G-tKEcnVw76-ZU77AjmBDGybLnNEOKjkJtYBN67es0wb30g@mail.gmail.com>
2015-09-23 17:53             ` Chris Mason
2015-09-23 18:24               ` Theodore Ts'o
     [not found]                 ` <CAF4G-t+E89a_A3RzQYB9wXxqE6nM0t7wN6fNmLABZ70=ivHTRQ@mail.gmail.com>
     [not found]                   ` <CAF4G-t+E89a_A3RzQYB9wXxqE6nM0t7wN6fNmLABZ70=ivHTRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-23 19:47                     ` Artem Bityutskiy
2015-09-23 20:48                       ` Theodore Ts'o
2015-09-24  8:13                         ` Artem Bityutskiy
     [not found]             ` <CAF4G-tKEcnVw76-ZU77AjmBDGybLnNEOKjkJtYBN67es0wb30g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-23 19:03               ` Tejun Heo
     [not found]         ` <1443012552.19983.209.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-23 18:09           ` Tejun Heo
     [not found]             ` <20150923180934.GE26647-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-23 18:51               ` Tejun Heo
2015-09-23 21:07                 ` [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Tejun Heo
2015-09-24  8:09                   ` Artem Bityutskiy
     [not found]                     ` <1443082186.19983.234.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-24  8:40                       ` Dexuan Cui
     [not found]                         ` <d6cf09f352a84b8d811da55fbc64a869-NHRYisGuqk8ni+flWUsx/pbBmlrREI7+ECdVDZe1NQc@public.gmane.org>
2015-09-24 20:47                           ` Tejun Heo
2015-09-28 21:39                             ` Tejun Heo
2015-09-24 20:45                       ` Tejun Heo
2015-09-25  6:49                         ` Artem Bityutskiy
     [not found]                           ` <1443163749.19983.254.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-25 10:50                             ` Artem Bityutskiy
2015-09-25 15:49                               ` Tejun Heo
2015-09-26  8:06                                 ` Artem Bityutskiy
2015-09-26 22:14                                   ` Tejun Heo
     [not found]                                     ` <20150926221413.GI3572-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-09-29 11:37                                       ` Artem Bityutskiy
2015-09-29 14:26                                         ` Tejun Heo
     [not found]                   ` <20150923210729.GA23180-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-24 16:17                     ` Jens Axboe
2015-09-24 20:48                   ` Tejun Heo
2015-07-12 18:05 ` [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
     [not found]   ` <20150712180520.GE18734-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-07-16 19:40     ` Tejun Heo
2015-07-16 23:21       ` Dave Chinner
2015-07-16 23:37         ` Tejun Heo
2015-07-17  1:37     ` Theodore Ts'o
2015-07-17 15:20       ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2015-06-12 22:02 [PATCHSET " Tejun Heo
2015-06-12 22:02 ` [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434495193-31182-2-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).