From: Matthew Wilcox <matthew.r.wilcox@intel.com>
To: linux-fsdevel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
Matthew Wilcox <willy@linux.intel.com>
Subject: [PATCH 5/5] vfs: Allow truncate, chomd and chown to be interrupted by fatal signals
Date: Mon, 29 Jun 2015 16:02:32 -0400 [thread overview]
Message-ID: <1435608152-6982-6-git-send-email-matthew.r.wilcox@intel.com> (raw)
In-Reply-To: <1435608152-6982-1-git-send-email-matthew.r.wilcox@intel.com>
If another task dies while holding the i_mutex, tasks trying to truncate,
chmod or chown the file will hang. Allowing a fatal interrupt to kill
the task is beneficial for the system administrator trying to get the
machine to shut down more cleanly.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
---
fs/open.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/open.c b/fs/open.c
index e0250bd..4b0061e 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -56,7 +56,8 @@ int do_truncate(struct dentry *dentry, loff_t length, unsigned int time_attrs,
if (ret)
newattrs.ia_valid |= ret | ATTR_FORCE;
- mutex_lock(&dentry->d_inode->i_mutex);
+ if (mutex_lock_killable(&dentry->d_inode->i_mutex))
+ return -EINTR;
/* Note any delegations or leases have already been broken: */
ret = notify_change(dentry, &newattrs, NULL);
mutex_unlock(&dentry->d_inode->i_mutex);
@@ -508,7 +509,8 @@ static int chmod_common(struct path *path, umode_t mode)
if (error)
return error;
retry_deleg:
- mutex_lock(&inode->i_mutex);
+ if (mutex_lock_killable(&inode->i_mutex))
+ return -EINTR;
error = security_path_chmod(path, mode);
if (error)
goto out_unlock;
@@ -591,7 +593,8 @@ retry_deleg:
if (!S_ISDIR(inode->i_mode))
newattrs.ia_valid |=
ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV;
- mutex_lock(&inode->i_mutex);
+ if (mutex_lock_killable(&inode->i_mutex))
+ return -EINTR;
error = security_path_chown(path, uid, gid);
if (!error)
error = notify_change(path->dentry, &newattrs, &delegated_inode);
--
2.1.4
prev parent reply other threads:[~2015-06-29 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 20:02 [PATCH 0/5] DAX updates for 4.2 Matthew Wilcox
2015-06-29 20:02 ` [PATCH 1/5] dax: Add block size note to documentation Matthew Wilcox
2015-06-29 20:02 ` [PATCH 2/5] dax: Use copy_from_iter_nocache Matthew Wilcox
2015-06-29 20:02 ` [PATCH 3/5] block: Add support for DAX on block devices Matthew Wilcox
2015-06-30 11:19 ` Christoph Hellwig
2015-06-30 19:56 ` Matthew Wilcox
2015-07-01 7:19 ` Christoph Hellwig
2015-06-29 20:02 ` [PATCH 4/5] ext4: Use ext4_get_block_write() for DAX Matthew Wilcox
2015-06-29 20:02 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435608152-6982-6-git-send-email-matthew.r.wilcox@intel.com \
--to=matthew.r.wilcox@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).