linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 2/2] f2fs: skip checkpoint if there is no dirty segments
Date: Mon, 10 Aug 2015 18:23:25 -0700	[thread overview]
Message-ID: <1439256205-8906-2-git-send-email-jaegeuk@kernel.org> (raw)
In-Reply-To: <1439256205-8906-1-git-send-email-jaegeuk@kernel.org>

We should avoid wrong checkpoints when there is no dirty segments.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/gc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index fcb263a..c4ed116 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -809,13 +809,14 @@ gc_more:
 	if (unlikely(f2fs_cp_error(sbi)))
 		goto stop;
 
+	if (!__get_victim(sbi, &segno, gc_type))
+		goto stop;
+
 	if (gc_type == BG_GC && has_not_enough_free_secs(sbi, nfree)) {
 		gc_type = FG_GC;
 		write_checkpoint(sbi, &cpc);
 	}
 
-	if (!__get_victim(sbi, &segno, gc_type))
-		goto stop;
 	ret = 0;
 
 	/* readahead multi ssa blocks those have contiguous address */
-- 
2.1.1


------------------------------------------------------------------------------

  reply	other threads:[~2015-08-11  1:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11  1:23 [PATCH 1/2] f2fs: increase the number of max hard links Jaegeuk Kim
2015-08-11  1:23 ` Jaegeuk Kim [this message]
2015-08-12  5:09   ` [PATCH 2/2 v2] f2fs: skip checkpoint if there is no dirty segments Jaegeuk Kim
2015-08-12  9:43     ` [f2fs-dev] " Chao Yu
2015-08-13  1:26       ` [PATCH 2/2 v3] " Jaegeuk Kim
2015-08-12  9:42 ` [f2fs-dev] [PATCH 1/2] f2fs: increase the number of max hard links Chao Yu
2015-08-14 23:22   ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439256205-8906-2-git-send-email-jaegeuk@kernel.org \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).