linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: stable <stable@vger.kernel.org>
Cc: Greg-KH <gregkh@linuxfoundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Miklos Szeredi <mszeredi@suse.cz>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH-v3.14.y 0/8] Stable backport for dcache shrink list corruption
Date: Thu, 13 Aug 2015 21:23:38 +0000	[thread overview]
Message-ID: <1439501026-19955-1-git-send-email-nab@linux-iscsi.org> (raw)

From: Nicholas Bellinger <nab@linux-iscsi.org>

Hi Greg-KH, Al, & Co,

So I've recently been repeatedly hitting the same dcache shrink list
corruption bug on v3.14.47 that has been addressed in >= v3.15 code,
but it appears only one of the fixes:

   commit 22213318af7ae265bc6cd8aef2febbc2d69a2440
   Author: Al Viro <viro@zeniv.linux.org.uk>
   Date:   Sat Apr 19 12:30:58 2014 -0400

       fix races between __d_instantiate() and checks of dentry flags

actually made it into v3.14.y code.

The final set of patches from Al, along with the original thread is here:

  https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg637332.html

The series cherry-picked clean into v3.14.y, with the minor exception
of needing to use the older dentry->d_child in __dentry_kill(), instead
of the newer dentry->d_u.d_child present in >= v3.15.y.

If there are no objections and/or concerns from Al, please consider
queueing this series to address the bug for other folks still using
v3.14.y code.

Thank you,

--nab

Al Viro (7):
  fold d_kill() and d_free()
  fold try_prune_one_dentry()
  new helper: dentry_free()
  expand the call of dentry_lru_del() in dentry_kill()
  dentry_kill(): don't try to remove from shrink list
  don't remove from shrink list in select_collect()
  more graceful recovery in umount_collect()

Miklos Szeredi (1):
  dcache: don't need rcu in shrink_dentry_list()

 fs/dcache.c            | 316 ++++++++++++++++---------------------------------
 include/linux/dcache.h |   2 +
 2 files changed, 103 insertions(+), 215 deletions(-)

-- 
1.8.5.3


             reply	other threads:[~2015-08-13 21:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 21:23 Nicholas A. Bellinger [this message]
2015-08-13 21:23 ` [PATCH-v3.14.y 1/8] fold d_kill() and d_free() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 2/8] fold try_prune_one_dentry() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 3/8] new helper: dentry_free() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 4/8] expand the call of dentry_lru_del() in dentry_kill() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 5/8] dentry_kill(): don't try to remove from shrink list Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 6/8] don't remove from shrink list in select_collect() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 7/8] more graceful recovery in umount_collect() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 8/8] dcache: don't need rcu in shrink_dentry_list() Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439501026-19955-1-git-send-email-nab@linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mszeredi@suse.cz \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).