From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: [PATCH-v3.14.y 0/8] Stable backport for dcache shrink list corruption Date: Thu, 13 Aug 2015 21:23:38 +0000 Message-ID: <1439501026-19955-1-git-send-email-nab@linux-iscsi.org> Cc: Greg-KH , Al Viro , Miklos Szeredi , linux-fsdevel , Nicholas Bellinger To: stable Return-path: Received: from mail.linux-iscsi.org ([67.23.28.174]:36953 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbbHMV3A (ORCPT ); Thu, 13 Aug 2015 17:29:00 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Nicholas Bellinger Hi Greg-KH, Al, & Co, So I've recently been repeatedly hitting the same dcache shrink list corruption bug on v3.14.47 that has been addressed in >= v3.15 code, but it appears only one of the fixes: commit 22213318af7ae265bc6cd8aef2febbc2d69a2440 Author: Al Viro Date: Sat Apr 19 12:30:58 2014 -0400 fix races between __d_instantiate() and checks of dentry flags actually made it into v3.14.y code. The final set of patches from Al, along with the original thread is here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg637332.html The series cherry-picked clean into v3.14.y, with the minor exception of needing to use the older dentry->d_child in __dentry_kill(), instead of the newer dentry->d_u.d_child present in >= v3.15.y. If there are no objections and/or concerns from Al, please consider queueing this series to address the bug for other folks still using v3.14.y code. Thank you, --nab Al Viro (7): fold d_kill() and d_free() fold try_prune_one_dentry() new helper: dentry_free() expand the call of dentry_lru_del() in dentry_kill() dentry_kill(): don't try to remove from shrink list don't remove from shrink list in select_collect() more graceful recovery in umount_collect() Miklos Szeredi (1): dcache: don't need rcu in shrink_dentry_list() fs/dcache.c | 316 ++++++++++++++++--------------------------------- include/linux/dcache.h | 2 + 2 files changed, 103 insertions(+), 215 deletions(-) -- 1.8.5.3