linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: stable <stable@vger.kernel.org>
Cc: Greg-KH <gregkh@linuxfoundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Miklos Szeredi <mszeredi@suse.cz>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: [PATCH-v3.14.y 3/8] new helper: dentry_free()
Date: Thu, 13 Aug 2015 21:23:41 +0000	[thread overview]
Message-ID: <1439501026-19955-4-git-send-email-nab@linux-iscsi.org> (raw)
In-Reply-To: <1439501026-19955-1-git-send-email-nab@linux-iscsi.org>

From: Al Viro <viro@zeniv.linux.org.uk>

commit b4f0354e968f5fabd39bc85b99fedae4a97589fe upstream.

The part of old d_free() that dealt with actual freeing of dentry.
Taken out of dentry_kill() into a separate function.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/dcache.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 1dc738a..3a0f252 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -244,6 +244,15 @@ static void __d_free(struct rcu_head *head)
 	kmem_cache_free(dentry_cache, dentry); 
 }
 
+static void dentry_free(struct dentry *dentry)
+{
+	/* if dentry was never visible to RCU, immediate free is OK */
+	if (!(dentry->d_flags & DCACHE_RCUACCESS))
+		__d_free(&dentry->d_u.d_rcu);
+	else
+		call_rcu(&dentry->d_u.d_rcu, __d_free);
+}
+
 /**
  * dentry_rcuwalk_barrier - invalidate in-progress rcu-walk lookups
  * @dentry: the target dentry
@@ -511,11 +520,7 @@ relock:
 	if (dentry->d_op && dentry->d_op->d_release)
 		dentry->d_op->d_release(dentry);
 
-	/* if dentry was never visible to RCU, immediate free is OK */
-	if (!(dentry->d_flags & DCACHE_RCUACCESS))
-		__d_free(&dentry->d_u.d_rcu);
-	else
-		call_rcu(&dentry->d_u.d_rcu, __d_free);
+	dentry_free(dentry);
 	return parent;
 }
 
-- 
1.8.5.3

  parent reply	other threads:[~2015-08-13 21:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 21:23 [PATCH-v3.14.y 0/8] Stable backport for dcache shrink list corruption Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 1/8] fold d_kill() and d_free() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 2/8] fold try_prune_one_dentry() Nicholas A. Bellinger
2015-08-13 21:23 ` Nicholas A. Bellinger [this message]
2015-08-13 21:23 ` [PATCH-v3.14.y 4/8] expand the call of dentry_lru_del() in dentry_kill() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 5/8] dentry_kill(): don't try to remove from shrink list Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 6/8] don't remove from shrink list in select_collect() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 7/8] more graceful recovery in umount_collect() Nicholas A. Bellinger
2015-08-13 21:23 ` [PATCH-v3.14.y 8/8] dcache: don't need rcu in shrink_dentry_list() Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439501026-19955-4-git-send-email-nab@linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mszeredi@suse.cz \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).