From: Jeff Moyer <jmoyer@redhat.com>
To: matthew.r.wilcox@intel.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@ml01.01.org
Subject: [PATCH 2/2] blockdev: don't set S_DAX for misaligned partitions
Date: Fri, 14 Aug 2015 16:15:32 -0400 [thread overview]
Message-ID: <1439583332-13754-3-git-send-email-jmoyer@redhat.com> (raw)
In-Reply-To: <1439583332-13754-1-git-send-email-jmoyer@redhat.com>
The dax code doesn't currently support misaligned partitions,
so disable O_DIRECT via dax until such time as that support
materializes.
Suggested-by: Boaz Harrosh <boaz@plexistor.com>
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
---
fs/block_dev.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 1982437..1170f8c 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1241,6 +1241,13 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
goto out_clear;
}
bd_set_size(bdev, (loff_t)bdev->bd_part->nr_sects << 9);
+ /*
+ * If the partition is not aligned on a page
+ * boundary, we can't do dax I/O to it.
+ */
+ if ((bdev->bd_part->start_sect % (PAGE_SIZE / 512)) ||
+ (bdev->bd_part->nr_sects % (PAGE_SIZE / 512)))
+ bdev->bd_inode->i_flags &= ~S_DAX;
}
} else {
if (bdev->bd_contains == bdev) {
--
1.8.3.1
next prev parent reply other threads:[~2015-08-14 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 20:15 [PATCH 0/2] fix regression in direct I/O to pmem devices Jeff Moyer
2015-08-14 20:15 ` [PATCH 1/2] dax: fix O_DIRECT I/O to the last block of a blockdev Jeff Moyer
2015-08-14 20:53 ` Linda Knippers
2015-09-08 16:10 ` Linda Knippers
2015-09-08 16:23 ` Dan Williams
2015-08-14 20:15 ` Jeff Moyer [this message]
2015-08-14 20:46 ` [PATCH 2/2] blockdev: don't set S_DAX for misaligned partitions Andreas Dilger
2015-08-14 20:55 ` Jeff Moyer
2015-08-14 20:22 ` [PATCH 0/2] fix regression in direct I/O to pmem devices Dan Williams
2015-08-14 20:23 ` Dan Williams
2015-08-14 20:27 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439583332-13754-3-git-send-email-jmoyer@redhat.com \
--to=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).