From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: fstests@vger.kernel.org
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chandan@mykolab.com
Subject: [PATCH] generic/224: Increase filesystem instance size to 1.5 GiB
Date: Sun, 30 Aug 2015 20:16:21 +0530 [thread overview]
Message-ID: <1440945981-323-1-git-send-email-chandan@linux.vnet.ibm.com> (raw)
For small filesystem instances (i.e. size <= 1 GiB), mkfs.btrfs fails when
"data block size" does not match with the "metadata block size" specified on
the mkfs.btrfs command line. This commit increases the size of filesystem
instance created so that the test can be executed on subpagesize-blocksize
Btrfs instances which have different values for data and metadata blocksizes.
Increasing the filesystem size had a negligible impact on the runtime of the
test as indicated by the following table:
|------------+--------------+----------------|
| Filesystem | 1GiB FS size | 1.5GiB FS size |
|------------+--------------+----------------|
| Btrfs | 21secs | 24secs |
| Ext4 | 12secs | 15secs |
| Xfs | 10secs | 11secs |
|------------+--------------+----------------|
Timing information reported in the above table were the worst-case times
observed when running the test on a spinning disk.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
tests/generic/224 | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/generic/224 b/tests/generic/224
index 391d877..8fae187 100755
--- a/tests/generic/224
+++ b/tests/generic/224
@@ -53,8 +53,9 @@ _supported_os Linux
_require_scratch
-# make a 1GB filesystem
-_scratch_mkfs_sized `expr 1024 \* 1024 \* 1024` > $seqres.full 2>&1
+# make a 1.5GB filesystem
+FS_SIZE=$(echo "1.5 $((1024 * 1024 * 1024))" | awk '{printf "%d", $1 * $2}')
+_scratch_mkfs_sized $FS_SIZE > $seqres.full 2>&1
_scratch_mount >> $seqres.full 2>&1
# set the reserved block pool to almost empty for XFS
--
2.1.0
next reply other threads:[~2015-08-30 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 14:46 Chandan Rajendra [this message]
2015-08-31 18:11 ` [PATCH] generic/224: Increase filesystem instance size to 1.5 GiB Theodore Ts'o
2015-08-31 19:19 ` Austin S Hemmelgarn
2015-08-31 21:09 ` Theodore Ts'o
2015-09-01 0:19 ` Chandan Rajendra
2015-09-01 0:38 ` Chandan Rajendra
2015-09-01 2:15 ` Theodore Ts'o
2015-09-01 2:33 ` Chandan Rajendra
2015-09-11 1:38 ` Qu Wenruo
2015-09-22 5:18 ` Chandan Rajendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440945981-323-1-git-send-email-chandan@linux.vnet.ibm.com \
--to=chandan@linux.vnet.ibm.com \
--cc=chandan@mykolab.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).