From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: <viro@ZenIV.linux.org.uk>, <jack@suse.cz>, <dedekind1@gmail.com>,
<richard.weinberger@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
linux-mtd@lists.infradead.org
Subject: [PATCH v3 03/39] fs: super: cleanup: make the comment of each function aligned
Date: Tue, 15 Sep 2015 17:01:58 +0800 [thread overview]
Message-ID: <1442307754-13233-4-git-send-email-yangds.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1442307754-13233-1-git-send-email-yangds.fnst@cn.fujitsu.com>
Originally, some of the comments start with "*\t" but some of them
start with "* ". This commit make them all start with "* "
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
fs/super.c | 180 ++++++++++++++++++++++++++++++-------------------------------
1 file changed, 90 insertions(+), 90 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index 72f9e1d..9589fa4 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -136,10 +136,10 @@ static unsigned long super_cache_count(struct shrinker *shrink,
}
/**
- * destroy_super - frees a superblock
- * @s: superblock to free
+ * destroy_super - frees a superblock
+ * @s: superblock to free
*
- * Frees a superblock.
+ * Frees a superblock.
*/
static void destroy_super(struct super_block *s)
{
@@ -156,12 +156,12 @@ static void destroy_super(struct super_block *s)
}
/**
- * alloc_super - create new superblock
- * @type: filesystem type superblock should belong to
- * @flags: the mount flags
+ * alloc_super - create new superblock
+ * @type: filesystem type superblock should belong to
+ * @flags: the mount flags
*
- * Allocates and initializes a new &struct super_block. alloc_super()
- * returns a pointer new superblock or %NULL if allocation had failed.
+ * Allocates and initializes a new &struct super_block. alloc_super()
+ * returns a pointer new superblock or %NULL if allocation had failed.
*/
static struct super_block *alloc_super(struct file_system_type *type, int flags)
{
@@ -252,11 +252,11 @@ static void __put_super(struct super_block *sb)
}
/**
- * put_super - drop a temporary reference to superblock
- * @sb: superblock in question
+ * put_super - drop a temporary reference to superblock
+ * @sb: superblock in question
*
- * Drops a temporary reference, frees superblock if there's no
- * references left.
+ * Drops a temporary reference, frees superblock if there's no
+ * references left.
*/
static void put_super(struct super_block *sb)
{
@@ -267,15 +267,15 @@ static void put_super(struct super_block *sb)
/**
- * deactivate_locked_super - drop an active reference to superblock
- * @s: superblock to deactivate
+ * deactivate_locked_super - drop an active reference to superblock
+ * @s: superblock to deactivate
*
- * Drops an active reference to superblock, converting it into a temprory
- * one if there is no other active references left. In that case we
- * tell fs driver to shut it down and drop the temporary reference we
- * had just acquired.
+ * Drops an active reference to superblock, converting it into a temprory
+ * one if there is no other active references left. In that case we
+ * tell fs driver to shut it down and drop the temporary reference we
+ * had just acquired.
*
- * Caller holds exclusive lock on superblock; that lock is released.
+ * Caller holds exclusive lock on superblock; that lock is released.
*/
void deactivate_locked_super(struct super_block *s)
{
@@ -302,12 +302,12 @@ void deactivate_locked_super(struct super_block *s)
EXPORT_SYMBOL(deactivate_locked_super);
/**
- * deactivate_super - drop an active reference to superblock
- * @s: superblock to deactivate
+ * deactivate_super - drop an active reference to superblock
+ * @s: superblock to deactivate
*
- * Variant of deactivate_locked_super(), except that superblock is *not*
- * locked by caller. If we are going to drop the final active reference,
- * lock will be acquired prior to that.
+ * Variant of deactivate_locked_super(), except that superblock is *not*
+ * locked by caller. If we are going to drop the final active reference,
+ * lock will be acquired prior to that.
*/
void deactivate_super(struct super_block *s)
{
@@ -319,17 +319,17 @@ void deactivate_super(struct super_block *s)
EXPORT_SYMBOL(deactivate_super);
/**
- * grab_super - acquire an active reference
- * @s: reference we are trying to make active
+ * grab_super - acquire an active reference
+ * @s: reference we are trying to make active
*
- * Tries to acquire an active reference. grab_super() is used when we
- * had just found a superblock in super_blocks or fs_type->fs_supers
- * and want to turn it into a full-blown active reference. grab_super()
- * is called with sb_lock held and drops it. Returns 1 in case of
- * success, 0 if we had failed (superblock contents was already dead or
- * dying when grab_super() had been called). Note that this is only
- * called for superblocks not in rundown mode (== ones still on ->fs_supers
- * of their type), so increment of ->s_count is OK here.
+ * Tries to acquire an active reference. grab_super() is used when we
+ * had just found a superblock in super_blocks or fs_type->fs_supers
+ * and want to turn it into a full-blown active reference. grab_super()
+ * is called with sb_lock held and drops it. Returns 1 in case of
+ * success, 0 if we had failed (superblock contents was already dead or
+ * dying when grab_super() had been called). Note that this is only
+ * called for superblocks not in rundown mode (== ones still on ->fs_supers
+ * of their type), so increment of ->s_count is OK here.
*/
static int grab_super(struct super_block *s) __releases(sb_lock)
{
@@ -346,21 +346,21 @@ static int grab_super(struct super_block *s) __releases(sb_lock)
}
/*
- * trylock_super - try to grab ->s_umount shared
- * @sb: reference we are trying to grab
+ * trylock_super - try to grab ->s_umount shared
+ * @sb: reference we are trying to grab
*
- * Try to prevent fs shutdown. This is used in places where we
- * cannot take an active reference but we need to ensure that the
- * filesystem is not shut down while we are working on it. It returns
- * false if we cannot acquire s_umount or if we lose the race and
- * filesystem already got into shutdown, and returns true with the s_umount
- * lock held in read mode in case of success. On successful return,
- * the caller must drop the s_umount lock when done.
+ * Try to prevent fs shutdown. This is used in places where we
+ * cannot take an active reference but we need to ensure that the
+ * filesystem is not shut down while we are working on it. It returns
+ * false if we cannot acquire s_umount or if we lose the race and
+ * filesystem already got into shutdown, and returns true with the s_umount
+ * lock held in read mode in case of success. On successful return,
+ * the caller must drop the s_umount lock when done.
*
- * Note that unlike get_super() et.al. this one does *not* bump ->s_count.
- * The reason why it's safe is that we are OK with doing trylock instead
- * of down_read(). There's a couple of places that are OK with that, but
- * it's very much not a general-purpose interface.
+ * Note that unlike get_super() et.al. this one does *not* bump ->s_count.
+ * The reason why it's safe is that we are OK with doing trylock instead
+ * of down_read(). There's a couple of places that are OK with that, but
+ * it's very much not a general-purpose interface.
*/
bool trylock_super(struct super_block *sb)
{
@@ -375,18 +375,18 @@ bool trylock_super(struct super_block *sb)
}
/**
- * generic_shutdown_super - common helper for ->kill_sb()
- * @sb: superblock to kill
+ * generic_shutdown_super - common helper for ->kill_sb()
+ * @sb: superblock to kill
*
- * generic_shutdown_super() does all fs-independent work on superblock
- * shutdown. Typical ->kill_sb() should pick all fs-specific objects
- * that need destruction out of superblock, call generic_shutdown_super()
- * and release aforementioned objects. Note: dentries and inodes _are_
- * taken care of and do not need specific handling.
+ * generic_shutdown_super() does all fs-independent work on superblock
+ * shutdown. Typical ->kill_sb() should pick all fs-specific objects
+ * that need destruction out of superblock, call generic_shutdown_super()
+ * and release aforementioned objects. Note: dentries and inodes _are_
+ * taken care of and do not need specific handling.
*
- * Upon calling this function, the filesystem may no longer alter or
- * rearrange the set of dentries belonging to this super_block, nor may it
- * change the attachments of dentries to inodes.
+ * Upon calling this function, the filesystem may no longer alter or
+ * rearrange the set of dentries belonging to this super_block, nor may it
+ * change the attachments of dentries to inodes.
*/
void generic_shutdown_super(struct super_block *sb)
{
@@ -424,12 +424,12 @@ void generic_shutdown_super(struct super_block *sb)
EXPORT_SYMBOL(generic_shutdown_super);
/**
- * sget - find or create a superblock
- * @type: filesystem type superblock should belong to
- * @test: comparison callback
- * @set: setup callback
- * @flags: mount flags
- * @data: argument to each of them
+ * sget - find or create a superblock
+ * @type: filesystem type superblock should belong to
+ * @test: comparison callback
+ * @set: setup callback
+ * @flags: mount flags
+ * @data: argument to each of them
*/
struct super_block *sget(struct file_system_type *type,
int (*test)(struct super_block *,void *),
@@ -491,12 +491,12 @@ void drop_super(struct super_block *sb)
EXPORT_SYMBOL(drop_super);
/**
- * iterate_supers - call function for all active superblocks
- * @f: function to call
- * @arg: argument to pass to it
+ * iterate_supers - call function for all active superblocks
+ * @f: function to call
+ * @arg: argument to pass to it
*
- * Scans the superblock list and calls given function, passing it
- * locked superblock and given argument.
+ * Scans the superblock list and calls given function, passing it
+ * locked superblock and given argument.
*/
void iterate_supers(void (*f)(struct super_block *, void *), void *arg)
{
@@ -525,13 +525,13 @@ void iterate_supers(void (*f)(struct super_block *, void *), void *arg)
}
/**
- * iterate_supers_type - call function for superblocks of given type
- * @type: fs type
- * @f: function to call
- * @arg: argument to pass to it
+ * iterate_supers_type - call function for superblocks of given type
+ * @type: fs type
+ * @f: function to call
+ * @arg: argument to pass to it
*
- * Scans the superblock list and calls given function, passing it
- * locked superblock and given argument.
+ * Scans the superblock list and calls given function, passing it
+ * locked superblock and given argument.
*/
void iterate_supers_type(struct file_system_type *type,
void (*f)(struct super_block *, void *), void *arg)
@@ -560,11 +560,11 @@ void iterate_supers_type(struct file_system_type *type,
EXPORT_SYMBOL(iterate_supers_type);
/**
- * get_super - get the superblock of a device
- * @bdev: device to get the superblock for
- *
- * Scans the superblock list and finds the superblock of the file system
- * mounted on the device given. %NULL is returned if no match is found.
+ * get_super - get the superblock of a device
+ * @bdev: device to get the superblock for
+ *
+ * Scans the superblock list and finds the superblock of the file system
+ * mounted on the device given. %NULL is returned if no match is found.
*/
struct super_block *get_super(struct block_device *bdev)
@@ -599,13 +599,13 @@ rescan:
EXPORT_SYMBOL(get_super);
/**
- * get_super_thawed - get thawed superblock of a device
- * @bdev: device to get the superblock for
+ * get_super_thawed - get thawed superblock of a device
+ * @bdev: device to get the superblock for
*
- * Scans the superblock list and finds the superblock of the file system
- * mounted on the device. The superblock is returned once it is thawed
- * (or immediately if it was not frozen). %NULL is returned if no match
- * is found.
+ * Scans the superblock list and finds the superblock of the file system
+ * mounted on the device. The superblock is returned once it is thawed
+ * (or immediately if it was not frozen). %NULL is returned if no match
+ * is found.
*/
struct super_block *get_super_thawed(struct block_device *bdev)
{
@@ -680,13 +680,13 @@ rescan:
}
/**
- * do_remount_sb - asks filesystem to change mount options.
- * @sb: superblock in question
- * @flags: numeric part of options
- * @data: the rest of options
+ * do_remount_sb - asks filesystem to change mount options.
+ * @sb: superblock in question
+ * @flags: numeric part of options
+ * @data: the rest of options
* @force: whether or not to force the change
*
- * Alters the mount options of a mounted file system.
+ * Alters the mount options of a mounted file system.
*/
int do_remount_sb(struct super_block *sb, int flags, void *data, int force)
{
--
1.8.4.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2015-09-15 9:01 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 9:01 [PATCH v3 00/39] Add quota supporting in ubifs Dongsheng Yang
2015-09-15 9:01 ` [PATCH v3 01/39] fs: introduce a ->s_cdev field into struct super_block Dongsheng Yang
2015-10-04 6:31 ` Christoph Hellwig
2015-10-05 8:36 ` Jan Kara
2015-09-15 9:01 ` [PATCH v3 02/39] fs: cleanup: remove the blank line before EXPORT_SYMBOL Dongsheng Yang
2015-09-15 9:01 ` Dongsheng Yang [this message]
2015-09-15 9:01 ` [PATCH v3 04/39] fs: super: consolidate the get_super class functions Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 05/39] fs: super: introduce a get_super_cdev to get super by a cdev reference Dongsheng Yang
2015-10-04 6:32 ` Christoph Hellwig
2015-09-15 9:02 ` [PATCH v3 06/39] fs: super: introduce a get_super_cdev_thawed to get sb by " Dongsheng Yang
2015-09-15 21:24 ` Jan Kara
2015-09-15 9:02 ` [PATCH v3 07/39] fs: char_dev: introduce cd_acquire function to acquire cdev Dongsheng Yang
2015-09-16 8:16 ` Jan Kara
2015-09-17 3:30 ` Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 08/39] fs: introduce a __lookup_dev for internal using Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 09/39] fs: char_dev: introduce lookup_cdev to get cdev by pathname Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 10/39] fs: dquot: skip invalidate_bdev if bdev is NULL Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 11/39] fs: quota: replace opened calling of ->sync_fs with sync_filesystem Dongsheng Yang
2015-09-16 10:14 ` Jan Kara
2015-09-17 6:28 ` Dongsheng Yang
2015-09-17 11:05 ` Jan Kara
2015-09-18 5:49 ` Dongsheng Yang
2015-09-18 9:00 ` Jan Kara
2015-09-21 4:31 ` Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 12/39] fs: quota: make quota support fs which is running on char dev Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 13/39] fs: introduce a get_qsize() to inode_operations Dongsheng Yang
2015-10-04 6:33 ` Christoph Hellwig
2015-10-05 8:01 ` Jan Kara
2015-09-15 9:02 ` [PATCH v3 14/39] fs: quota: restore i_flags of quota files in dquot_disable Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 15/39] fs: quota: introduce a callback of restore_iflags to quotactl_ops Dongsheng Yang
2015-09-16 9:47 ` Jan Kara
2015-09-15 9:02 ` [PATCH v3 16/39] ubi: introduce a interface to get cdev in ubi_volume Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 17/39] ubifs: extend budget for blocks Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 18/39] ubifs: fill sb->s_cdev in ubifs_fill_super() Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 19/39] ubifs: fill ->s_dev in ubifs_fill_super Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 20/39] ubifs: export read_block() from file.c Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 21/39] ubifs: introduce i_dquot to ubifs_inode Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 22/39] ubifs: implement IO functions for quota files Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 23/39] ubifs: disable quota in ubifs_put_super Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 24/39] ubifs: write quota back in ubifs_sync Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 25/39] ubifs: set/clear MS_RDONLY properly in ubifs_remount Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 26/39] ubifs: suspend & resume quota " Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 27/39] ubifs: check inode with NULL before using it Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 28/39] ubifs: record quota information about inode in ubifs_new_inode Dongsheng Yang
2015-09-15 9:35 ` Sheng Yong
2015-09-16 1:46 ` Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 29/39] ubifs: free quota inode information in ubifs_evict_inode Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 30/39] ubifs: alloc quota space in ubifs writing path Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 31/39] ubifs: free quota space in do_truncation Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 32/39] ubifs: free quota space when deleting a file Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 33/39] ubifs: adapt quota space informatin in do_setattr Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 34/39] ubifs: transfer quota information in changing owner or group Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 35/39] ubifs: write inode in ubifs_quota_write if we are appending Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 36/39] ubifs: implement ubifs_get_qsize to get quota size in ubifs Dongsheng Yang
2015-09-16 10:00 ` Jan Kara
2015-09-17 7:23 ` Dongsheng Yang
2015-09-17 12:00 ` Jan Kara
2015-09-18 6:14 ` Dongsheng Yang
2015-09-18 11:20 ` Jan Kara
2015-09-21 4:35 ` Dongsheng Yang
2015-09-21 9:13 ` Jan Kara
2015-09-21 9:16 ` Dongsheng Yang
2015-09-21 9:44 ` Jan Kara
2015-09-21 11:02 ` Dongsheng Yang
2015-09-23 7:42 ` Jan Kara
2015-09-24 0:50 ` Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 37/39] ubifs: implement ubifs_restore_iflags for quotactl_operations Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 38/39] ubifs: fill the quota related fields in ubifs_fill_super Dongsheng Yang
2015-09-15 9:02 ` [PATCH v3 39/39] ubifs: introduce quota related mount options Dongsheng Yang
2015-09-15 9:36 ` Sheng Yong
2015-09-16 1:48 ` Dongsheng Yang
2015-10-03 18:57 ` [PATCH v3 00/39] Add quota supporting in ubifs Richard Weinberger
2015-10-04 2:32 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442307754-13233-4-git-send-email-yangds.fnst@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=dedekind1@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).