From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: <viro@ZenIV.linux.org.uk>, <jack@suse.cz>, <dedekind1@gmail.com>,
	<richard.weinberger@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
	Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
	linux-mtd@lists.infradead.org
Subject: [PATCH v3 06/39] fs: super: introduce a get_super_cdev_thawed to get sb by cdev reference
Date: Tue, 15 Sep 2015 17:02:01 +0800	[thread overview]
Message-ID: <1442307754-13233-7-git-send-email-yangds.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1442307754-13233-1-git-send-email-yangds.fnst@cn.fujitsu.com>
This patch refactors the original get_super_thawed to get a common
helper function of __get_super_thawed. Then take the use of
__get_super_thawed, we can implement get_super_cdev_thawed easily.
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
---
 fs/super.c         | 29 +++++++++++++++++++++++++----
 include/linux/fs.h |  1 +
 2 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index 321d16b..df32393 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -629,18 +629,20 @@ struct super_block *get_super_cdev(struct cdev *cdev)
 EXPORT_SYMBOL(get_super_cdev);
 
 /**
- * get_super_thawed - get thawed superblock of a device
- * @bdev: device to get the superblock for
+ * __get_super_thawed - get thawed superblock
+ * @func: function pointer to get superblock by key
+ * @key: key to find superblock
  *
  * Scans the superblock list and finds the superblock of the file system
  * mounted on the device. The superblock is returned once it is thawed
  * (or immediately if it was not frozen). %NULL is returned if no match
  * is found.
  */
-struct super_block *get_super_thawed(struct block_device *bdev)
+static struct super_block *__get_super_thawed(
+		int (*compare)(struct super_block *, void *), void *key)
 {
 	while (1) {
-		struct super_block *s = get_super(bdev);
+		struct super_block *s = __get_super(compare, key);
 		if (!s || s->s_writers.frozen == SB_UNFROZEN)
 			return s;
 		up_read(&s->s_umount);
@@ -649,9 +651,28 @@ struct super_block *get_super_thawed(struct block_device *bdev)
 		put_super(s);
 	}
 }
+
+/**
+ * get_super_thawed - get thawed superblock of a device
+ * @bdev: device to get the superblock for
+ */
+struct super_block *get_super_thawed(struct block_device *bdev)
+{
+	return __get_super_thawed(bdev_compare, bdev);
+}
 EXPORT_SYMBOL(get_super_thawed);
 
 /**
+ * get_super_cdev_thawed - get thawed superblock of a char device
+ * @cdev: device to get the superblock for
+ */
+struct super_block *get_super_cdev_thawed(struct cdev *cdev)
+{
+	return __get_super_thawed(cdev_compare, cdev);
+}
+EXPORT_SYMBOL(get_super_cdev_thawed);
+
+/**
  * get_active_super - get an active reference to the superblock of a device
  * @bdev: device to get the superblock for
  *
diff --git a/include/linux/fs.h b/include/linux/fs.h
index df71cbb..2c1c122 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2798,6 +2798,7 @@ extern struct file_system_type *get_fs_type(const char *name);
 extern struct super_block *get_super(struct block_device *);
 extern struct super_block *get_super_cdev(struct cdev *);
 extern struct super_block *get_super_thawed(struct block_device *);
+extern struct super_block *get_super_cdev_thawed(struct cdev *);
 extern struct super_block *get_active_super(struct block_device *bdev);
 extern void drop_super(struct super_block *sb);
 extern void iterate_supers(void (*)(struct super_block *, void *), void *);
-- 
1.8.4.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply	other threads:[~2015-09-15  9:02 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  9:01 [PATCH v3 00/39] Add quota supporting in ubifs Dongsheng Yang
2015-09-15  9:01 ` [PATCH v3 01/39] fs: introduce a ->s_cdev field into struct super_block Dongsheng Yang
2015-10-04  6:31   ` Christoph Hellwig
2015-10-05  8:36     ` Jan Kara
2015-09-15  9:01 ` [PATCH v3 02/39] fs: cleanup: remove the blank line before EXPORT_SYMBOL Dongsheng Yang
2015-09-15  9:01 ` [PATCH v3 03/39] fs: super: cleanup: make the comment of each function aligned Dongsheng Yang
2015-09-15  9:01 ` [PATCH v3 04/39] fs: super: consolidate the get_super class functions Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 05/39] fs: super: introduce a get_super_cdev to get super by a cdev reference Dongsheng Yang
2015-10-04  6:32   ` Christoph Hellwig
2015-09-15  9:02 ` Dongsheng Yang [this message]
2015-09-15 21:24   ` [PATCH v3 06/39] fs: super: introduce a get_super_cdev_thawed to get sb by " Jan Kara
2015-09-15  9:02 ` [PATCH v3 07/39] fs: char_dev: introduce cd_acquire function to acquire cdev Dongsheng Yang
2015-09-16  8:16   ` Jan Kara
2015-09-17  3:30     ` Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 08/39] fs: introduce a __lookup_dev for internal using Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 09/39] fs: char_dev: introduce lookup_cdev to get cdev by pathname Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 10/39] fs: dquot: skip invalidate_bdev if bdev is NULL Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 11/39] fs: quota: replace opened calling of ->sync_fs with sync_filesystem Dongsheng Yang
2015-09-16 10:14   ` Jan Kara
2015-09-17  6:28     ` Dongsheng Yang
2015-09-17 11:05       ` Jan Kara
2015-09-18  5:49         ` Dongsheng Yang
2015-09-18  9:00           ` Jan Kara
2015-09-21  4:31             ` Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 12/39] fs: quota: make quota support fs which is running on char dev Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 13/39] fs: introduce a get_qsize() to inode_operations Dongsheng Yang
2015-10-04  6:33   ` Christoph Hellwig
2015-10-05  8:01     ` Jan Kara
2015-09-15  9:02 ` [PATCH v3 14/39] fs: quota: restore i_flags of quota files in dquot_disable Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 15/39] fs: quota: introduce a callback of restore_iflags to quotactl_ops Dongsheng Yang
2015-09-16  9:47   ` Jan Kara
2015-09-15  9:02 ` [PATCH v3 16/39] ubi: introduce a interface to get cdev in ubi_volume Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 17/39] ubifs: extend budget for blocks Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 18/39] ubifs: fill sb->s_cdev in ubifs_fill_super() Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 19/39] ubifs: fill ->s_dev in ubifs_fill_super Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 20/39] ubifs: export read_block() from file.c Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 21/39] ubifs: introduce i_dquot to ubifs_inode Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 22/39] ubifs: implement IO functions for quota files Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 23/39] ubifs: disable quota in ubifs_put_super Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 24/39] ubifs: write quota back in ubifs_sync Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 25/39] ubifs: set/clear MS_RDONLY properly in ubifs_remount Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 26/39] ubifs: suspend & resume quota " Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 27/39] ubifs: check inode with NULL before using it Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 28/39] ubifs: record quota information about inode in ubifs_new_inode Dongsheng Yang
2015-09-15  9:35   ` Sheng Yong
2015-09-16  1:46     ` Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 29/39] ubifs: free quota inode information in ubifs_evict_inode Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 30/39] ubifs: alloc quota space in ubifs writing path Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 31/39] ubifs: free quota space in do_truncation Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 32/39] ubifs: free quota space when deleting a file Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 33/39] ubifs: adapt quota space informatin in do_setattr Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 34/39] ubifs: transfer quota information in changing owner or group Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 35/39] ubifs: write inode in ubifs_quota_write if we are appending Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 36/39] ubifs: implement ubifs_get_qsize to get quota size in ubifs Dongsheng Yang
2015-09-16 10:00   ` Jan Kara
2015-09-17  7:23     ` Dongsheng Yang
2015-09-17 12:00       ` Jan Kara
2015-09-18  6:14         ` Dongsheng Yang
2015-09-18 11:20           ` Jan Kara
2015-09-21  4:35             ` Dongsheng Yang
2015-09-21  9:13               ` Jan Kara
2015-09-21  9:16                 ` Dongsheng Yang
2015-09-21  9:44                   ` Jan Kara
2015-09-21 11:02                     ` Dongsheng Yang
2015-09-23  7:42                       ` Jan Kara
2015-09-24  0:50                         ` Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 37/39] ubifs: implement ubifs_restore_iflags for quotactl_operations Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 38/39] ubifs: fill the quota related fields in ubifs_fill_super Dongsheng Yang
2015-09-15  9:02 ` [PATCH v3 39/39] ubifs: introduce quota related mount options Dongsheng Yang
2015-09-15  9:36   ` Sheng Yong
2015-09-16  1:48     ` Dongsheng Yang
2015-10-03 18:57 ` [PATCH v3 00/39] Add quota supporting in ubifs Richard Weinberger
2015-10-04  2:32   ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1442307754-13233-7-git-send-email-yangds.fnst@cn.fujitsu.com \
    --to=yangds.fnst@cn.fujitsu.com \
    --cc=dedekind1@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.weinberger@gmail.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).