linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Chris Mason <clm@fb.com>,
	linux-ext4@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
	axboe@kernel.dk, Tejun Heo <tj@kernel.org>,
	linux-fsdevel@vger.kernel.org, lizefan@huawei.com,
	cgroups@vger.kernel.org, adilger.kernel@dilger.ca,
	kernel-team@fb.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ext4: implement cgroup writeback support
Date: Thu, 24 Sep 2015 11:13:38 +0300	[thread overview]
Message-ID: <1443082418.19983.238.camel@gmail.com> (raw)
In-Reply-To: <20150923204846.GI3318@thunk.org>

On Wed, 2015-09-23 at 16:48 -0400, Theodore Ts'o wrote:
> On Wed, Sep 23, 2015 at 10:47:16PM +0300, Artem Bityutskiy wrote:
> > And, by the way, I forgot this detail - I cut AC power off at the
> > end, then put it back on after a 20 seconds delay. I mean, this is
> > a
> > clean reboot, but with power cut at the end.
> 
> Is this reproducible without the power cut?  And what model SSD are
> you using, and are you sure that it has Power Loss Protection (many
> SSD vendors use power loss protection as the price discrimination
> feature between consumer-grade SSD and enterprise-grade SSD's that
> cost $$$).  If this problem wasn't showing up with 4.2, and is only
> failing with 4.3-rcX, then it might not be a hardware issue --- but
> it's also possible that there was a timing issue which was hiding a
> hardware problem.  So for the purposes of debugging, removing the
> power cut from the set of variables is a useful thing to do.

Ted, you are right that the problem may be anywhere, but since Tejun's
patch fixes it, I decided to not spend time on testing without AC power
cuts.

But I checked and on of my boxes uses an HDD, and it shows the same
problem, which makes the theory of imperfect SSD firmware being
involved less likely.

Thanks,
Artem.

  reply	other threads:[~2015-09-24  8:13 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 22:53 [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-06-16 22:53 ` [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc Tejun Heo
     [not found]   ` <1434495193-31182-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-07-22  3:56     ` Theodore Ts'o
2015-06-16 22:53 ` [PATCH 2/2] ext4: implement cgroup writeback support Tejun Heo
     [not found]   ` <1434495193-31182-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-07-22  3:56     ` Theodore Ts'o
2015-09-23 12:49       ` Artem Bityutskiy
2015-09-23 13:50         ` Artem Bityutskiy
2015-09-23 17:02           ` Theodore Ts'o
2015-09-23 17:57             ` Tejun Heo
2015-09-23 17:25         ` Chris Mason
     [not found]           ` <CAF4G-tKEcnVw76-ZU77AjmBDGybLnNEOKjkJtYBN67es0wb30g@mail.gmail.com>
2015-09-23 17:53             ` Chris Mason
2015-09-23 18:24               ` Theodore Ts'o
     [not found]                 ` <CAF4G-t+E89a_A3RzQYB9wXxqE6nM0t7wN6fNmLABZ70=ivHTRQ@mail.gmail.com>
     [not found]                   ` <CAF4G-t+E89a_A3RzQYB9wXxqE6nM0t7wN6fNmLABZ70=ivHTRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-23 19:47                     ` Artem Bityutskiy
2015-09-23 20:48                       ` Theodore Ts'o
2015-09-24  8:13                         ` Artem Bityutskiy [this message]
     [not found]             ` <CAF4G-tKEcnVw76-ZU77AjmBDGybLnNEOKjkJtYBN67es0wb30g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-23 19:03               ` Tejun Heo
     [not found]         ` <1443012552.19983.209.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-23 18:09           ` Tejun Heo
     [not found]             ` <20150923180934.GE26647-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-23 18:51               ` Tejun Heo
2015-09-23 21:07                 ` [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Tejun Heo
2015-09-24  8:09                   ` Artem Bityutskiy
     [not found]                     ` <1443082186.19983.234.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-24  8:40                       ` Dexuan Cui
     [not found]                         ` <d6cf09f352a84b8d811da55fbc64a869-NHRYisGuqk8ni+flWUsx/pbBmlrREI7+ECdVDZe1NQc@public.gmane.org>
2015-09-24 20:47                           ` Tejun Heo
2015-09-28 21:39                             ` Tejun Heo
2015-09-24 20:45                       ` Tejun Heo
2015-09-25  6:49                         ` Artem Bityutskiy
     [not found]                           ` <1443163749.19983.254.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-25 10:50                             ` Artem Bityutskiy
2015-09-25 15:49                               ` Tejun Heo
2015-09-26  8:06                                 ` Artem Bityutskiy
2015-09-26 22:14                                   ` Tejun Heo
     [not found]                                     ` <20150926221413.GI3572-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-09-29 11:37                                       ` Artem Bityutskiy
2015-09-29 14:26                                         ` Tejun Heo
     [not found]                   ` <20150923210729.GA23180-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-09-24 16:17                     ` Jens Axboe
2015-09-24 20:48                   ` Tejun Heo
2015-07-12 18:05 ` [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
     [not found]   ` <20150712180520.GE18734-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-07-16 19:40     ` Tejun Heo
2015-07-16 23:21       ` Dave Chinner
2015-07-16 23:37         ` Tejun Heo
2015-07-17  1:37     ` Theodore Ts'o
2015-07-17 15:20       ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2015-06-12 22:02 [PATCHSET " Tejun Heo
2015-06-12 22:02 ` [PATCH 2/2] " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443082418.19983.238.camel@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=clm@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).