From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yaowei Bai Subject: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check Date: Mon, 28 Sep 2015 22:11:19 +0800 Message-ID: <1443449479-5379-1-git-send-email-bywxiaobai@163.com> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: viro@zeniv.linux.org.uk, mikulas@artax.karlin.mff.cuni.cz Return-path: Received: from m12-18.163.com ([220.181.12.18]:52426 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757039AbbI1Oeo (ORCPT ); Mon, 28 Sep 2015 10:34:44 -0400 In-Reply-To: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/hpfs/namei.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 9e92c9c..ae4d5a1 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c @@ -227,8 +227,6 @@ static int hpfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, de int err; if ((err = hpfs_chk_name(name, &len))) return err==-ENOENT ? -EINVAL : err; if (hpfs_sb(dir->i_sb)->sb_eas < 2) return -EPERM; - if (!new_valid_dev(rdev)) - return -EINVAL; hpfs_lock(dir->i_sb); err = -ENOSPC; fnode = hpfs_alloc_fnode(dir->i_sb, hpfs_i(dir)->i_dno, &fno, &bh); -- 1.9.1