From: Vinson Lee <vlee@twopensource.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ivan Delalande <colona@arista.com>,
Omar Sandoval <osandov@osandov.com>,
stable@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, Vinson Lee <vlee@twitter.com>
Subject: [PATCH stable request 3.10] vfs: Remove incorrect debugging WARN in prepend_path
Date: Mon, 28 Sep 2015 16:17:29 -0700 [thread overview]
Message-ID: <1443482250-30691-1-git-send-email-vlee@twopensource.com> (raw)
From: Vinson Lee <vlee@twitter.com>
Hi.
Please backport upstream 4.2 commit 93e3bce6287e1fb3e60d3324ed08555b5bbafa89
("vfs: Remove incorrect debugging WARN in prepend_path") to stable kernel 3.10.
This patch has already been backported to stable kernels 3.12, 3.13, 3.14,
3.16, 3.18, 4.0, and 4.1.
The upstream patch does not apply cleanly and a backport is provided.
This patch fixes 3.13 commit f48cfddc6729e
("vfs: In d_path don't call d_dname on a mount point"), but this patch was
itself was backported in 3.10.28.
This patch addresses this warning seen in 3.10.76.
------------[ cut here ]------------
WARNING: at fs/dcache.c:2576 prepend_path+0x12b/0x17c()
Root dentry has weird name <>
Modules linked in: sch_fq_codel sch_htb cls_basic act_mirred cls_u32 veth sch_ingress netconsole configfs ipv6 dm_multipath scsi_dh video sbs sbshc hed acpi_pad a
parport_pc lp parport tcp_diag inet_diag ipmi_si ipmi_devintf ipmi_msghandler dell_rbu sg iTCO_wdt iTCO_vendor_support dcdbas igb i2c_algo_bit ptp pps_core i7cor
ioatdma i2c_i801 shpchp i2c_core lpc_ich microcode dca mfd_core freq_table mperf ahci libahci libata sd_mod scsi_mod
CPU: 9 PID: 13242 Comm: lsof Tainted: G D W 3.10.76 #1
0000000000000000 ffff880b28ef3da0 ffffffff8146857f ffff880b28ef3dd8
ffffffff8103cc01 ffff880b28ef3de8 ffff88060275fa20 ffff8803d4dbb740
ffff88060275fa00 0000000000000000 ffff880b28ef3e38 ffffffff8103cc65
Call Trace:
[<ffffffff8146857f>] dump_stack+0x19/0x1b
[<ffffffff8103cc01>] warn_slowpath_common+0x65/0x7d
[<ffffffff8103cc65>] warn_slowpath_fmt+0x4c/0x4e
[<ffffffff8113dd5b>] prepend_path+0x12b/0x17c
[<ffffffff8113de85>] d_path+0xd9/0x139
[<ffffffff8117c35a>] proc_pid_readlink+0x6e/0xd9
[<ffffffff81131202>] SyS_readlinkat+0x93/0xdc
[<ffffffff81131266>] SyS_readlink+0x1b/0x1d
[<ffffffff81473262>] system_call_fastpath+0x16/0x1b
---[ end trace a4b19d6c8a8b2eec ]---
Cheers,
Vinson
Eric W. Biederman (1):
vfs: Remove incorrect debugging WARN in prepend_path
fs/dcache.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
next reply other threads:[~2015-09-28 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 23:17 Vinson Lee [this message]
2015-09-28 23:17 ` [PATCH] vfs: Remove incorrect debugging WARN in prepend_path Vinson Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443482250-30691-1-git-send-email-vlee@twopensource.com \
--to=vlee@twopensource.com \
--cc=colona@arista.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vlee@twitter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).