From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: [PATCH 2/2] f2fs: don't need to submit bio on error case Date: Wed, 21 Oct 2015 20:03:44 -0700 Message-ID: <1445483024-49724-2-git-send-email-jaegeuk@kernel.org> References: <1445483024-49724-1-git-send-email-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Return-path: In-Reply-To: <1445483024-49724-1-git-send-email-jaegeuk@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org If commit_atomic_write is failed, we don't need to submit any bio. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 7835e41..7efd96ad 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -249,11 +249,11 @@ int commit_inmem_pages(struct inode *inode, bool abort) trace_f2fs_commit_inmem_page(cur->page, INMEM); fio.page = cur->page; err = do_write_data_page(&fio); - submit_bio = true; if (err) { unlock_page(cur->page); break; } + submit_bio = true; } } else { trace_f2fs_commit_inmem_page(cur->page, INMEM_DROP); -- 2.1.1 ------------------------------------------------------------------------------