linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hpe.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-nvdimm <linux-nvdimm@ml01.01.org>,
	Ross Zwisler <ross.zwisler@intel.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: dax pmd fault handler never returns to userspace
Date: Wed, 18 Nov 2015 15:04:41 -0700	[thread overview]
Message-ID: <1447884281.21443.154.camel@hpe.com> (raw)
In-Reply-To: <CAPcyv4g5LoOZH81JfB+xTKXs5cSxZogTfFUyQqq1U8h=aNrjuw@mail.gmail.com>

On Wed, 2015-11-18 at 13:57 -0800, Dan Williams wrote:
> On Wed, Nov 18, 2015 at 1:33 PM, Toshi Kani <toshi.kani@hpe.com> wrote:
> > I am seeing a similar/same problem in my test.  I think the problem is that
> > in
> > case of a WP fault, wp_huge_pmd() -> __dax_pmd_fault() ->
> > vmf_insert_pfn_pmd(),
> > which is a no-op since the PMD is mapped already.  We need WP handling for
> > this
> > PMD map.
> > 
> > If it helps, I have attached change for follow_trans_huge_pmd().  I have not
> > tested much, though.
> 
> Interesting, I didn't get this far because my tests were crashing the
> kernel.  I'll add this case the pmd fault test in ndctl.

I hit this one with mmap(MAP_POPULATE).  With this change, I then hit the WP
fault loop when writing to the range.

Thanks,
-Toshi 


  reply	other threads:[~2015-11-18 22:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 15:53 dax pmd fault handler never returns to userspace Jeff Moyer
2015-11-18 15:56 ` Zwisler, Ross
2015-11-18 16:52 ` Dan Williams
2015-11-18 17:00   ` Ross Zwisler
2015-11-18 17:43     ` Jeff Moyer
2015-11-18 18:10       ` Dan Williams
2015-11-18 18:23         ` Ross Zwisler
2015-11-18 18:32           ` Jeff Moyer
2015-11-18 18:53             ` Ross Zwisler
2015-11-18 18:58               ` Dan Williams
2015-11-19 22:34                 ` Dave Chinner
2015-11-18 21:33           ` Toshi Kani
2015-11-18 21:57             ` Dan Williams
2015-11-18 22:04               ` Toshi Kani [this message]
2015-11-19  0:36                 ` Ross Zwisler
2015-11-19  0:39                   ` Dan Williams
2015-11-19  1:05                   ` Toshi Kani
2015-11-19  1:19                   ` Dan Williams
2015-11-18 18:30         ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447884281.21443.154.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=ross.zwisler@intel.com \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).