From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:34725 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbbK2XDj (ORCPT ); Sun, 29 Nov 2015 18:03:39 -0500 Received: by padhx2 with SMTP id hx2so164116441pad.1 for ; Sun, 29 Nov 2015 15:03:38 -0800 (PST) Message-ID: <1448838216.4582.12.camel@ubuntu-slavad-14.04> Subject: Re: [PATCH 2/2] HFS: clear dirty flags on remount read-only From: Vyacheslav Dubeyko To: Timo =?ISO-8859-1?Q?Schl=FC=DFler?= Cc: linux-fsdevel@vger.kernel.org Date: Sun, 29 Nov 2015 15:03:36 -0800 In-Reply-To: <565B12E5.3090600@schluessler.org> References: <565B12E5.3090600@schluessler.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Timo, On Sun, 2015-11-29 at 15:59 +0100, Timo Schlüßler wrote: > Remounting a HFS filesystem read-only doesn't clear the "DIRTY"-flags (not > HFS_SB_ATTRIB_UNMNT and HFS_SB_ATTRIB_INCNSTNT) correctly. Subsequent > mounts then report a dirty filesystem and enforce a check before willing to > mount it read-write again. > Signed-off-by: Timo Schlüßler > --- > > --- linux/fs/hfs/super.c.orig 2015-11-29 14:42:22.000000000 +0100 > +++ linux/fs/hfs/super.c 2015-11-29 15:22:03.000000000 +0100 > @@ -113,11 +113,13 @@ static int hfs_statfs(struct dentry *den > > static int hfs_remount(struct super_block *sb, int *flags, char *data) > { > - sync_filesystem(sb); I think that this is the right placement for sync_filesystem() call. It's much better to have such call in one place. Anyway, you need to set HFS_SB_ATTRIB_UNMNT and to clear HFS_SB_ATTRIB_INCNSTNT for remount from READ-WRITE to READ-ONLY state. And vou need to do opposite operation for remount from READ-ONLY to READ-WRITE state. So, it's much better ti leave sync_filesystem() call in the same place but to add additional logic before this call. Thanks, Vyacheslav Dubeyko. > *flags |= MS_NODIRATIME; > - if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) > + if ((*flags & MS_RDONLY) == (sb->s_flags & MS_RDONLY)) { > + sync_filesystem(sb); > return 0; > + } > if (!(*flags & MS_RDONLY)) { > + sync_filesystem(sb); > if (!(HFS_SB(sb)->mdb->drAtrb & cpu_to_be16(HFS_SB_ATTRIB_UNMNT))) { > pr_warn("filesystem was not cleanly unmounted, running fsck.hfs is recommended. leaving read-only.\n"); > sb->s_flags |= MS_RDONLY; > @@ -127,6 +129,9 @@ static int hfs_remount(struct super_bloc > sb->s_flags |= MS_RDONLY; > *flags |= MS_RDONLY; > } > + } else { > + hfs_mdb_close(sb); > + sync_filesystem(sb); > } > return 0; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html