From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 16/31] IGET: Stop FreeVXFS from using iget() and read_inode() [try #5] Date: Tue, 06 Nov 2007 11:13:36 +0000 Message-ID: <1449.1194347616@redhat.com> References: <1363.1194347363@redhat.com> <20071106022505.f32b1bff.akpm@linux-foundation.org> <20071025163352.5057.59344.stgit@warthog.procyon.org.uk> <20071025163514.5057.4558.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: unlisted-recipients:; (no To-header on input) Return-path: Received: from mx1.redhat.com ([66.187.233.31]:50154 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756278AbXKFLNa (ORCPT ); Tue, 6 Nov 2007 06:13:30 -0500 In-Reply-To: <1363.1194347363@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org David Howells wrote: > > Not completely trivial - the ino_t -> unsigned long conversion needs to be > > propagated fairly widely in there. > > I'll just make it unsigned long. That's what iget() took as the inode number > parameter type, so it can't behave any differently as a first guess. On the other hand, __vxfs_iget() takes ino_t, so that's the right thing to do in this case. David