linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 6/6] f2fs: avoid needless sync_inode_page when reading inline_data
Date: Mon, 25 Jan 2016 14:05:31 -0800	[thread overview]
Message-ID: <1453759531-16076-6-git-send-email-jaegeuk@kernel.org> (raw)
In-Reply-To: <1453759531-16076-1-git-send-email-jaegeuk@kernel.org>

In write_begin, if there is an inline_data, f2fs loads it into 0'th data page.
Since it's the read path, we don't need to sync its inode page.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/data.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index a6a6f08..4e992bf 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1464,7 +1464,6 @@ restart:
 			read_inline_data(page, ipage);
 			set_inode_flag(F2FS_I(inode), FI_DATA_EXIST);
 			set_inline_node(ipage);
-			sync_inode_page(&dn);
 		} else {
 			err = f2fs_convert_inline_page(&dn, page);
 			if (err)
-- 
2.6.3


      parent reply	other threads:[~2016-01-25 22:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 22:05 [PATCH 1/6] f2fs: speed up shrinking extent_node cache Jaegeuk Kim
2016-01-25 22:05 ` [PATCH 2/6] f2fs: give scheduling point in shrinking path Jaegeuk Kim
2016-01-25 22:05 ` [PATCH 3/6] f2fs: do f2fs_balance_fs when block is allocated Jaegeuk Kim
2016-01-25 22:05 ` [PATCH 4/6] f2fs: avoid multiple node page writes due to inline_data Jaegeuk Kim
2016-01-26  5:41   ` [f2fs-dev] " Chao Yu
2016-01-26 18:48     ` Jaegeuk Kim
2016-01-27  6:28       ` Chao Yu
2016-01-25 22:05 ` [PATCH 5/6] f2fs: don't need to sync node page at every time Jaegeuk Kim
2016-01-25 22:05 ` Jaegeuk Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453759531-16076-6-git-send-email-jaegeuk@kernel.org \
    --to=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).