From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-security-module <linux-security-module@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ima: add support for creating files using the mknodat syscall
Date: Tue, 15 Mar 2016 12:26:36 -0400 [thread overview]
Message-ID: <1458059196.2662.4.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160315143601.GI17997@ZenIV.linux.org.uk>
On Tue, 2016-03-15 at 14:36 +0000, Al Viro wrote:
> On Tue, Mar 15, 2016 at 09:43:11AM -0400, Mimi Zohar wrote:
> > +void ima_post_path_mknod(struct dentry *dentry)
> > +{
> > + struct integrity_iint_cache *iint;
> > + struct inode *inode;
> > + int must_appraise;
> > +
> > + if (!dentry || !dentry->d_inode)
>
> In which situations is that condition supposed to be true?
Never, removing tests.
Mimi
prev parent reply other threads:[~2016-03-15 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 13:43 [PATCH v2 0/2] ima: tar issues Mimi Zohar
2016-03-15 13:43 ` [PATCH v2 1/2] ima: fix ima_inode_post_setattr Mimi Zohar
2016-03-15 13:43 ` [PATCH v2 2/2] ima: add support for creating files using the mknodat syscall Mimi Zohar
2016-03-15 14:36 ` Al Viro
2016-03-15 16:26 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458059196.2662.4.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).