Re: [RFC v2] [PATCH 0/10] DAX page fault locking

[Toshi Kani <toshi.kani@hpe.com>]

On Wed, 2016-03-23 at 10:45 +0100, Jan Kara wrote:
> On Tue 22-03-16 15:07:33, Toshi Kani wrote:
> > On Tue, 2016-03-22 at 13:32 -0600, Ross Zwisler wrote:
> > > On Mon, Mar 21, 2016 at 02:22:45PM +0100, Jan Kara wrote:
> > > > [Sorry for repost but I accidentally sent initial email without
> > > > patches]
> > > > 
> > > > Hello,
> > > > 
> > > > this is my second attempt at DAX page fault locking rewrite. Things
> > > > now work reasonably well, it has survived full xfstests run on
> > > > ext4. I guess I need to do more mmap targetted tests to unveil
> > > > issues. Guys what do you used for DAX testing?
> > > 
> > > I typically use xfstests for regression testing.  If we can come up
> > > with new generally useful regression tests, especially ones
> > > concerning mmap races, that would be awesome.  I guess it's just a
> > > choice between adding them somewhere in xfstests or somewhere else
> > > like with the unit tests in ndctl.
> > 
> > Brian Boylston wrote a test for mmap race conditions and posted it
> > before.  This test was very useful to fix the data corruption issue we
> > had before.
> > http://www.spinics.net/lists/linux-ext4/msg49876.html
> > 
> > If there is anything we can do to make this test useful as regression
> > tests?
> 
> Thanks for the pointer, I forgot about this useful test. As Dave said the
> best way for this to not get lost is to include it in xfstests. Since I
> want to run the test regularly anyway, I can integrate it myself.

Great! Thanks Jan!
-Toshi