From: Ian Kent <raven@themaw.net>
To: Omar Sandoval <osandov@osandov.com>
Cc: autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: Autofs and mount namespaces
Date: Fri, 08 Apr 2016 09:21:07 +0800 [thread overview]
Message-ID: <1460078467.3135.50.camel@themaw.net> (raw)
In-Reply-To: <20160407181911.GA9018@vader>
On Thu, 2016-04-07 at 11:19 -0700, Omar Sandoval wrote:
> diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
> index 0146d911f468..b4e901d2aa6b 100644
> --- a/fs/autofs4/waitq.c
> +++ b/fs/autofs4/waitq.c
> @@ -332,8 +332,6 @@ static int validate_request(struct
> autofs_wait_queue **wait,
> dentry = new;
> }
> }
> - if (have_submounts(dentry))
> - valid = 0;
LOL, that's going to break rootless multi-mounts.
Consider the case where you have:
<key> /one a_server:/path \
/two any_other:/any_other_path \
....
The ability to check that the non-mountpoint dentry is in fact the root
of a mounted tree of mounts is gone, ;)
Ian
prev parent reply other threads:[~2016-04-08 1:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:19 Autofs and mount namespaces Omar Sandoval
2016-04-07 19:08 ` kbuild test robot
2016-04-07 19:42 ` Omar Sandoval
2016-04-08 0:51 ` Ian Kent
2016-04-08 1:04 ` Ian Kent
2016-04-08 20:21 ` Omar Sandoval
2016-04-10 2:53 ` Ian Kent
2016-07-05 18:47 ` Omar Sandoval
2016-07-05 23:35 ` Ian Kent
2016-09-13 18:19 ` Omar Sandoval
2016-09-14 0:56 ` Ian Kent
2016-09-14 1:25 ` Omar Sandoval
2016-04-08 1:21 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460078467.3135.50.camel@themaw.net \
--to=raven@themaw.net \
--cc=autofs@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).