From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53637 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbcDHBVX (ORCPT ); Thu, 7 Apr 2016 21:21:23 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E491D20F78 for ; Thu, 7 Apr 2016 21:21:11 -0400 (EDT) Message-ID: <1460078467.3135.50.camel@themaw.net> Subject: Re: Autofs and mount namespaces From: Ian Kent To: Omar Sandoval Cc: autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@fb.com Date: Fri, 08 Apr 2016 09:21:07 +0800 In-Reply-To: <20160407181911.GA9018@vader> References: <20160407181911.GA9018@vader> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 2016-04-07 at 11:19 -0700, Omar Sandoval wrote: > diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c > index 0146d911f468..b4e901d2aa6b 100644 > --- a/fs/autofs4/waitq.c > +++ b/fs/autofs4/waitq.c > @@ -332,8 +332,6 @@ static int validate_request(struct > autofs_wait_queue **wait, > dentry = new; > } > } > - if (have_submounts(dentry)) > - valid = 0; LOL, that's going to break rootless multi-mounts. Consider the case where you have: /one a_server:/path \ /two any_other:/any_other_path \ .... The ability to check that the non-mountpoint dentry is in fact the root of a mounted tree of mounts is gone, ;) Ian