From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from g1t5425.austin.hp.com ([15.216.225.55]:42688 "EHLO
	g1t5425.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754519AbcEEO20 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 5 May 2016 10:28:26 -0400
Message-ID: <1462457965.27137.93.camel@hpe.com>
Subject: Re: [PATCH v2-UPDATE 3/3] xfs: Add alignment check for DAX mount
From: Toshi Kani <toshi.kani@hpe.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dan.j.williams@intel.com, david@fromorbit.com, jack@suse.cz,
	linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
	micah.parrish@hpe.com, adilger.kernel@dilger.ca,
	linux-fsdevel@vger.kernel.org, tytso@mit.edu
Date: Thu, 05 May 2016 08:19:25 -0600
In-Reply-To: <20160505142144.GA3601@infradead.org>
References: <1462376761-15584-1-git-send-email-toshi.kani@hpe.com>
	 <20160505142144.GA3601@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 2016-05-05 at 07:21 -0700, Christoph Hellwig wrote:
> > 
> >  	if (mp->m_flags & XFS_MOUNT_DAX) {
> > +		struct blk_dax_ctl dax = {
> > +			.sector = 0,
> > +			.size = PAGE_SIZE,
> > +		};
>
> I'm pretty sure I already complained last week, but this boiler plate
> code has no business in every file systems.  Also it seems to me like
> this struct blk_dax_ctl calling convention is stupid to start with,
> why not pass the arguments directly and avoid the boilerplate code
> everywhere?

Sorry, I was wondering about if we should also consolidate error messages.
Per the thread below, I am going to add a helper function to do it.
https://lkml.org/lkml/2016/5/4/887

Thanks,
-Toshi