From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from g4t3426.houston.hp.com ([15.201.208.54]:16067 "EHLO
	g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751626AbcEIWnP (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 9 May 2016 18:43:15 -0400
Message-ID: <1462833254.27137.113.camel@hpe.com>
Subject: Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount
 checks
From: Toshi Kani <toshi.kani@hpe.com>
To: Dave Chinner <david@fromorbit.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>,
	Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@infradead.org>,
	Boaz Harrosh <boaz@plexistor.com>,
	Theodore Ts'o <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	micah.parrish@hpe.com,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Mon, 09 May 2016 16:34:14 -0600
In-Reply-To: <20160509211903.GW18496@dastard>
References: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com>
	 <1462494596-20938-3-git-send-email-toshi.kani@hpe.com>
	 <CAPcyv4hKpvF6uqBzV+1seUzFfxDZM-ApordAL_NecRLNcdNgwg@mail.gmail.com>
	 <1462817565.27137.102.camel@hpe.com>
	 <CAPcyv4g6mPsmHM6OSTi78n_KBKCZrb1ou90=xWuhc7eGyx0DPg@mail.gmail.com>
	 <20160509211903.GW18496@dastard>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote:
> On Mon, May 09, 2016 at 11:23:03AM -0700, Dan Williams wrote:
> > 
> > On Mon, May 9, 2016 at 11:12 AM, Toshi Kani <toshi.kani@hpe.com> wrote:
> > > 
> > > On Sun, 2016-05-08 at 12:14 -0700, Dan Williams wrote:
> > > > 
> > > > On Thu, May 5, 2016 at 5:29 PM, Toshi Kani <toshi.kani@hpe.com>
> > > > wrote:
 :
> > > > This patch should replace blkdev_dax_capable(), or just reuse that
> > > > existing routine, or am I missing something?
> > >
> > > Good question.  bdev_supports_dax() is a helper function tailored for
> > > the filesystem's mount -o dax case.  While blkdev_dax_capable() is
> > > similar, it does not need error messages like "device does not
> > > support dax" since it implicitly enables dax when capable.  So, I
> > > think we can keep blkdev_dax_capable(), but change it to call
> > > bdev_direct_access() so that actual check is performed in a single
> > > place.
> >
> > Sounds good to me.
>
> Can you name them consistently then? i.e. blkdev_dax_supported() and
> blkdev_dax_capable()?

Sure.  Will do.

Thanks,
-Toshi